Koenkk / zigbee-herdsman-converters

Collection of device converters to be used with zigbee-herdsman
MIT License
863 stars 2.85k forks source link

Add manuSpecificIkeaUnknown #7615

Closed sjorge closed 1 month ago

sjorge commented 1 month ago

Rebase after https://github.com/Koenkk/zigbee-herdsman-converters/pull/7614

Shows up on newer ikea devices and some devices that had a FW update post DIRIGERA. Potentially needs to be added to more devices, but I added it on the ones I could verify had it, or devices sharing a fw with devices I verified. e.g. all ikea blinds seem to share the same base firmware, so I added it to all of them.

I also observed some devices like STARKVIND, GUNNARP panel 40*40, FLOALT panel WS 30x90, and FLOALT panel WS 30x30 not having it. These devices have not had a new FW release since DIRIGERA to my knowledge. So we can't just add it to all devices.

Since there are no known attributes, it's purely cosmetic but my weird itch is scratched, no more random numeric clusters on my IKEA devices. If we do every somehow get incoming date from one it should be easier to spot now.

Screenshot 2024-06-08 at 16 32 17

As per discord, It's OK to close and not merge this. But I was in here for the other 2 clusters anyway so not much effort to just do this one too.

Koenkk commented 1 month ago

Thanks!

sjorge commented 1 month ago

@Koenkk not sure you have may ikea devices I don't have, but if you do. Might be worth checking of others need it too. I presume some will.

Koenkk commented 1 month ago

Im wondering if we should add all manuspecific IKEA clusters to all IKEA devices, that prevents maintenance even when devies get OTAed

sjorge commented 1 month ago

Im wondering if we should add all manuspecific IKEA clusters to all IKEA devices, that prevents maintenance even when devies get OTAed

I don't think it makes sense for some very specific ones, like the STARKVIND and VINDSTYRKA clusters, they don't even use the same one for there pm25 for example.

It might make sense specifically for manuSpecificIkeaUnknown though, It's either going to be present or not. Don't think it will be an issue if it's not present and we add it.

Koenkk commented 1 month ago

Exactly, so that might be the easiest for now

sjorge commented 1 month ago

Exactly, so that might be the easiest for now

I'll do a PR