search

Koenkk / zigbee-herdsman-converters

Collection of device converters to be used with zigbee-herdsman
MIT License
886 stars 2.96k forks source link

Omit battery_low for models that don't have it #7677

Closed deviantintegral closed 3 months ago

deviantintegral commented 3 months ago

The devices in this PR don't seem to actually ever send a battery alarm. I've only ever seen them report "normal" in z2m. I've been running a sniffer for 24 hours and zbee_zcl_general.power_config.attr_id > 0x0021 shows no results. If I'm reading https://github.com/Koenkk/zigbee-herdsman/blob/73162478f5e5c3d9058bfada27dfff52b9d2c612/src/zspec/zcl/definition/cluster.ts#L71 right, if reported it should be reported with attribute ID 0x3E.

Also, I've never had this value flip before a battery dies, so I don't think it is just waiting for a failure state to send.

Koenkk commented 3 months ago

Thanks!