Koenkk / zigbee-herdsman-converters

Collection of device converters to be used with zigbee-herdsman
MIT License
858 stars 2.83k forks source link

Fix for TS0601_soil_2 tze284 g2e6cpnw datapoint mapping #7710

Open rare-magma opened 5 days ago

rare-magma commented 5 days ago

I think the datapoint mappings need to be reviewed for this device following the discussion in https://github.com/Koenkk/zigbee-herdsman-converters/pull/7609#issuecomment-2198030719

rare-magma commented 5 days ago

@xpavli44 I just tried these changes via an external converter and got the following message from the device:

{
    "dpValues": [
        {
            "data": { "data": [0, 0, 0, 21], "type": "Buffer" },
            "datatype": 2,
            "dp": 3
        },
        {
            "data": { "data": [0, 0, 0, 254], "type": "Buffer" },
            "datatype": 2,
            "dp": 5
        },
        {
            "data": { "data": [0, 0, 3, 9], "type": "Buffer" },
            "datatype": 2,
            "dp": 110
        }
    ],
    "seq": 9219
}

I think the datapoints 5 and 110 correspond to the same temperature reading, the first one is in celsius and the other in fahrenheit.

xpavli44 commented 5 days ago

@rare-magma

I think the datapoints 5 and 110 correspond to the same temperature reading, the first one is in celsius and the other in fahrenheit.

indeed I made the same observation independently