Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
454 stars 278 forks source link

Set correct manufacturerCode for Robert Bosch GmbH #1003

Closed burmistrzak closed 1 month ago

burmistrzak commented 1 month ago

Reworking the known manufacturer codes seemingly caused the wrong manufacturerCode (0x1133) to be set for custom clusters by Robert Bosch GmbH (0x1209).

Fix for Bosch Twinguard: No converter available for 8750001213

TheMagnetar commented 1 month ago

Is this going to break https://www.zigbee2mqtt.io/devices/RADON_TriTech_ZB.html? It is developed by BOSCH Security systems

Are the other devices by Bosch affected?

Edit: I do not own any of these so I cannot test.

burmistrzak commented 1 month ago

Well, technically all Zigbee devices from Bosch, implementing their custom clusters, are affected. This hotfix is simply restoring the previous, correct manufacturerCode (i.e. 0x1209) for these devices.

If some device worked before, It'll most likely continue to do so.

TheMagnetar commented 1 month ago

Well, technically all Zigbee devices from Bosch, implementing their custom clusters, are affected. This hotfix is simply restoring the previous, correct manufacturerCode (i.e. 0x1209) for these devices.

If some device worked before, It'll most likely continue to do so.

Thanks for taking your time to answer my concern.

Koenkk commented 1 month ago

Thanks!