fix(ignore): remove all ubisys custom cluster/attributes

Koenkk / zigbee-herdsman

A Node.js Zigbee library

MIT License

456 stars 277 forks source link

fix(ignore): remove all ubisys custom cluster/attributes #1034

Closed sjorge closed 2 weeks ago

sjorge commented 3 weeks ago

Merge after https://github.com/Koenkk/zigbee-herdsman-converters/pull/7451

sjorge commented 3 weeks ago

For the tests, we will probably hit this again once we remove more of those attributes.

sjorge commented 2 weeks ago

Oh boy, this mrege conflict is a big pain I might close and redo this PR from scratch. The tests are the biggest pain as we basically removed all the problem childs from ubisys were we have so many tests for.

Koenkk commented 2 weeks ago

Could you rebase this PR?

sjorge commented 2 weeks ago

Could you rebase this PR?

I am trying but I'm having a really hard time, the tests are broken again and I am pretty sure I rebased those correctly :/

sjorge commented 2 weeks ago

It seems more tests got added that use ubisys attributes between me opening this one? :/

Koenkk commented 2 weeks ago

In this PR probably: https://github.com/Koenkk/zigbee-herdsman/commit/f88b4d64ed6e96e52b709fa98c7110686e84180c

sjorge commented 2 weeks ago

Seems to have been a miss-rebase with {} being added in some spots

Koenkk commented 2 weeks ago

Thanks!