Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
482 stars 300 forks source link

Add manuSpecificLumi curtain attributes #1149

Closed marthubner closed 3 months ago

marthubner commented 3 months ago

Based on https://github.com/Koenkk/zigbee-herdsman-converters/pull/7848

Koenkk commented 3 months ago

Could you use the custom cluster functionality in zigbee herdsmand converters instead? Look at lumi.ts for an example

marthubner commented 3 months ago

There is no custom cluster in lumi.ts but I found an example in ikea.ts at STARKVIND namely "export function addCustomClusterManuSpecificIkeaAirPurifier()", is that what you mean? Is it preferable to do this kind of thing with all the manuSpecificLumi attributes introduced with Aqara C3 curtain motor or is it fine the way it is now? Also why not add it here?

Koenkk commented 3 months ago

Because we want to get rid of the custom clusters in zigbee-herdsman, you can find another example here