Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
482 stars 300 forks source link

Fix missing response for readReportConfig command #1235

Closed canardos closed 1 week ago

canardos commented 1 week ago

Add support for readReportConfigRsp.

It is possible to send a ZCL readReportConfig command via Endpoint.zclCommand, but two issues prevent the response from working.

Firstly, although the readReportConfigRsp command is defined in the Foundation object, the response field that should reference it is missing from the readReportConfig command.

The second problem is that the first parameter (status) is missing from the readReportConfigRsp properties (see ZCL rev.8 section 2.5.10). This results in the read of all other attributes being off by 1-byte and an error being thrown in Utils.getDataTypeClass because dataType has been incorrectly read as 0.

This PR fixes both issues.

Koenkk commented 1 week ago

Thanks!