search

Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
485 stars 301 forks source link

Bump serialport version to 10.4.0 #540

Closed ercksen closed 2 years ago

ercksen commented 2 years ago

Hey, I am having struggle to use this library on NodeJS versions > 12.

It seems that the version of serialport is kind of old and the @serialport/bindings package is officially marked as deprecated and replaced by @serialport/bindings-cpp.

I have also seen quite some users having problems after updating the NodeJS version. There could also be some information inside the README about version requirements.

The output I get:

The module 'node_modules/zigbee-herdsman/node_modules/@serialport/bindings/build/Release/bindings.node' smart-hub-smarthub-backend-1 | was compiled against a different Node.js version using smart-hub-smarthub-backend-1 | NODE_MODULE_VERSION 72. This version of Node.js requires smart-hub-smarthub-backend-1 | NODE_MODULE_VERSION 93. Please try re-compiling or re-installing smart-hub-smarthub-backend-1 | the module (for instance, usingnpm rebuildornpm install)

Trying to bump the version on my own was not a great success. It would be nice to make this project compatible with newer versions.

Please correct me if I'm wrong and just don't know how to install this lib correctly.

ercksen commented 2 years ago

I finally fixed the issue by installing the correct binaries. The problem were different node versions between installation and execution of the modules so wrong binaries were installed.

But I will keep the issue open in order to decide whether it could be useful anyways to update to the new package.

Koenkk commented 2 years ago

The current @serialport/bindings-cpp has some issues with the prebuilt binaries and therefore we did not update yet:

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days