Closed Tarik2142 closed 1 year ago
Thanks for the PR, in order to get this merged:
npm run test-with-coverage
should pass)Thanks for the PR, in order to get this merged:
- Make sure to add tests for this (
npm run test-with-coverage
should pass)- Create a PR to update the docs (https://github.com/koenkk/zigbee2mqtt.io/)
Ok, thanks for the reply. I think there will be no problems with the documentation, but I've never written tests, so I'll have to figure it out. I ran a local check and somehow it passes. Here on github everything correctly shows that there are no tests for lines 85-115 I would be grateful for a hint why the local check is passing
Can you try to do a npm ci
and then a npm run-test-with-coverage
?
Can you try to do a
npm ci
and then anpm run-test-with-coverage
?Can you try to do a
npm ci
and then anpm run-test-with-coverage
?
Unfortunately that didn't help so I'll look here sometimes. Also, I got a strange thing in the test system, when passing the LoggerStub to the Adapter, the logger for some reason still remains undefined and causes an error
why line 107 is uncovered? do i need to check all radio types?
After the PR to the documentation, I will update the code and add a links to the documentation in the error messages
So the links exceed the length limit, how should I shorten them?
@Koenkk PR to docs is ready https://github.com/Koenkk/zigbee2mqtt.io/pull/2028
@Tarik2142 I made some updates, can you check if everything is still ok? If yes, I will merge this.
@Koenkk Tested the changes on my installation. Everything works.
Also tested handling of some errors, except the wrong packet, this requires changing the firmware of the coordinator
Great, thanks for this cool feature!
@Tarik2142 sorry for the ping; what functionalities this PR would bring to a user? I am just curious about it 👀
@Tarik2142 sorry for the ping; what functionalities this PR would bring to a user? I am just curious about it 👀
https://www.zigbee2mqtt.io/guide/configuration/adapter-settings.html#mdns-zeroconf-discovery If your coordinator supports this functionality, you can type mdns name in the configuration, IP, port and adapter type will be determined automatically. Even if the IP of the adapter changes, it will still be found. This simplifies the configuration
I described everything in the request here #https://github.com/Koenkk/zigbee2mqtt/issues/17430 I don't know much about typescript so improvements are welcome