Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
457 stars 279 forks source link

[ember][tempfix] Skip port re-init on reset retry #945

Closed Nerivec closed 3 months ago

Nerivec commented 3 months ago

Seems the RESET_WATCHDOG firmware issue is indeed plaguing SkyConnect/Yellow according to early 1.36 reports with ember... Since it appears to be linked to the opening of the serial port, I believe this should offer a temp fix until the firmware trouble can be resolved. It prevents a true clean slate on restart, but I guess for now it will have to do... The impact should only be on serial/writer/parser, so I don't think too many troubles should arise from it...

NOTE: While I tested the reset logic to work as I expected, I can't actually test on a SkyConnect/Yellow since I don't have one... i.e. attempting a fix blindfolded...

Koenkk commented 3 months ago

Thanks!