Koenkk / zigbee-herdsman

A Node.js Zigbee library
MIT License
456 stars 277 forks source link

[ember] Increase default NCP config + edge case device leave support #970

Closed Nerivec closed 2 months ago

Nerivec commented 2 months ago

Add some more firmware current defaults for reference + links. Increase default NCP configuration for max children and binding table. The changes are pretty drastic, but the initial values were actually very low compared to all the firmware defaults out there.

Allow Z2M to know when an ID conflict forced the stack to remove devices (edge case scenario). Allow lookup by network address in Controller>onDeviceLeave to make this work without extra NCP call.

Move default APS options to const.

Nerivec commented 2 months ago

@Koenkk Please confirm controller test/logic as expected. PS: I have to fix that darn coverage bug on my machine :(

Koenkk commented 2 months ago

Thanks!