search

Koenkk / zigbee2mqtt-chart

Helm Chart for Zigbee2MQTT
7 stars 7 forks source link

[FR] Adding Mosquitto as a separate chart with a dependency #2

Closed NigelVanHattum closed 5 months ago

NigelVanHattum commented 5 months ago

Since Mosquitto is mentioned as the default MQTT broker for Z2M in the getting started docs.

Could we perhaps add a new chart for Mosquitto and add that as a dependency to the main chart? If wanted, I could try to work on this

jlpedrosa commented 5 months ago

Actually if you go to the mosquitto GH, there's already a PR to create the chart.

NigelVanHattum commented 5 months ago

Just linking it here, so we can add the dependency once it's merged and released.

Initial Helm Chart implementation #3036

jlpedrosa commented 5 months ago

Honestly I would not add the dependency here, technically you can use different MQTT implementations not just mosquito. I Would also not pull home assistant into this chart. It also forces to release new versions of this chart when mosquitto is updated. I don't mind adding some examples if it becomes an official chart. But personally I don't think it's a good idea to try to create an stack out of this chart.

pmarques commented 5 months ago

I share @jlpedrosa's opinion.

NigelVanHattum commented 5 months ago

Makes sense, I was suggesting it since the docs clearly mention it.