search

Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge 🌉, get rid of your proprietary Zigbee bridges 🔨
https://www.zigbee2mqtt.io
GNU General Public License v3.0
11.79k stars 1.64k forks source link

permit_join false not honored - Aqara Router Devices #1580

Closed M0uC0 closed 5 years ago

M0uC0 commented 5 years ago

Hello,

My setup is not honoring the permit_join: false HA plugin 1.4.0,, CC2531 with '20190425' firmware.

I have a bunch of Xiaomi Devices acting like routers. 10 units - ZNCZ02LM - Xiaomi Mi power plug ZigBee (Router) 1 unit - JTQJ-BF-01LM/BW - Xiaomi MiJia gas leak detector 1 unit - LLKZMK11LM - Xiaomi Aqara wireless relay controller (Router)

And i think it is related to that.. I've read some closed posts mentioning similar problems.

With: zigbee2mqtt/bridge/config/# {"version":"1.4.0","commit":"unknown","coordinator":20190425,"log_level":"info","permit_join":false}

having a subscription on: zigbee2mqtt/bridge/log/# I manage to see that every new device connects.. and pairs without my authorization.

Anyone with the same kind of problem? I don't have a second cc2531 to sniff and debug..

Any ideas? best regards.

Koenkk commented 5 years ago

Does it only happen to devices that had already been connected to the network?

M0uC0 commented 5 years ago

Nope.. with new devices. Devices never paired with my CC2531 zigbee network. I have a bunch of xiaomi wireless switches i don't need and i've been testing with them.

After posting the issue i managed to see that if i turn all the "xiaomi routers" off, no new pairings occur with permit_join:false As soon as i turn on the xiaomi routers again, unauthorized new devices start to manage to pair again..

Any suggestions? Best regards.

Koenkk commented 5 years ago

Could you share your zigbee sniff log when pairing a device with permit join disabled? (http://www.zigbee2mqtt.io/how_tos/how_to_sniff_zigbee_traffic.html)

M0uC0 commented 5 years ago

Only have one CC2531.. the one that i currently use on my zigbee network and that i need to be working to have my home operational.. I have to buy another one..... till then.. no sniffing possible..

Koenkk commented 5 years ago

Can you try changing 255 on https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/zigbee.js#L192 and https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/zigbee.js#L202 to 240 and https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/zigbee.js#L214 to return this.shepherd.controller._permitJoinTime > 0;

This should automatically close the network after 240 seconds when permit join is false.

M0uC0 commented 5 years ago

Back home.. I'll try. feedback soon..

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.