Closed ristoavila closed 1 year ago
@zegl @sjorge what would be wise here; adding the effects for every bulb is a lot of work, would it be an idea to enable it for all lights and then disable it again for those where it doesn't work for?
Is there a clear mapping between the ones listed in the pdf and how we list them?If so, I guess going over the while list by next month might be doable if we do in small batches.~ sjorgeOn 6 Feb 2023, at 17:24, Koen Kanters @.***> wrote: @zegl @sjorge what would be wise here; adding the effects for every bulb is a lot of work, would it be an idea to enable it for all lights and then disable it again for those where it doesn't work for?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
I would enable it to all philips lights and then disable it if some one complains it doesn't work. I would also expect philips to roll more effects in the futures and enable those through FW updates.
There is also similar mapping as you have in https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/devices/philips.js e.g. one can find the model 1742930P7 from the previously posted web page with this exact model name.
I could also contribute to herdsman-converters but not sure how to enable effects as e.g. 1742930P7 is different from 1743030P7. First one has disableHueEffects and next one doesn't have any extra parameters.
One more thing to mention is that I'm only checking the z2mqtt web UI and under there the effect drop down is missing the candle light etc in both cases 1742930P7 and 1743030P7.
So Art Code column seems to line up with the zigbeeModel. Let me take a crack at getting the ones from the PDF updated.
I'm about 3 pages in and it seems like so far it's like nearly all of them, turning it on by default and disabling as needed is indeed the way to go.
Hi all,
I believe some hue firmwares for white ambiance support candlelight and a couple of other effects but not the full range of effects that the colour bulbs support. Would the proposal and PR here work with both types of bulb?
I still wonder where the gui gets the list of supported effects. The two models I have listed only few of the effects and all of the enum defined ones were missing e.g. the changs the listing. e done removes the listing. this seem to remove all the items. I had everything else visible in the gui expect the candle and others defined in the enum here https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/lib/philips.js on line 45
I still wonder where the gui gets the list of supported effects. The two models I have listed only few of the effects and all of the enum defined ones were missing e.g. the changs the listing. e done removes the listing. this seem to remove all the items. I had everything else visible in the gui expect the candle and others defined in the enum here https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/lib/philips.js on line 45
The few that used light_onoff_brightness
I tested were not on the list in the PDF. The expose templates for light_onoff_brightness_colortemp
, light_onoff_brightness_color
, and light_onoff_brightness_colortemp_color
have the list hardcoded, depending if there is just colortemp or colorxy support the set is different.
If there are indeed some onoff_brightness ones that also support effects (I didn't find any at quick glance) we need to drop the last commit in the PR.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days
What happened?
Philips has added the candle light and other effects to their hue series and some models are missing these. E.g. I'm using 1743030P7 and 1742930P7 lamps and those miss new effects which are part of the firmware updates.
I also found a list describing which models supports effects https://www.assets.signify.com/is/content/Signify/Assets/hue/united-states/20220124-effects-compatible-lights.pdf
What did you expect to happen?
I would expect under device effects there are newly added effects listed.
How to reproduce it (minimal and precise)
No response
Zigbee2MQTT version
1.30
Adapter firmware version
20221226
Adapter
Texas Instruments LAUNCHXL-CC26X2R1
Debug log
No response