search

Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge 🌉, get rid of your proprietary Zigbee bridges 🔨
https://www.zigbee2mqtt.io
GNU General Public License v3.0
12.04k stars 1.67k forks source link

Last Seen setting enabled breaks Inovelli VZM31-SN get exposes from device #16609

Closed mbrink123 closed 5 months ago

mbrink123 commented 1 year ago

What happened?

After installing a new Inovelli Blue switch (vzm31-sn) all the settings on the exposes tab of the device in Z2M say null. There is a blue refresh button that pulls the config from the switch and updates Z2M. If Z2M has the Settings--Advanced--Last Seen setting set to ISO_8601_local the blue refresh button wont pull any data from the switch. If you disable the last seen setting, you then get data when clicking the blue refresh button. Enabling the last seen setting will again break pulling data from the switch.

What did you expect to happen?

When clicking the blue refresh button, it should pull whatever data is in the Inovelli switch and display the information in Z2M on the exposes tab.

How to reproduce it (minimal and precise)

Change the "last seen" setting in Z2M (settings--advanced--last seen) to ISO_8601_local, add a new inovelli switch to Z2M, go to the device page for that switch, goto the exposes tab, scroll down to any setting that is blank and click the refresh button (nothing will happen). Go back into settings and set the "last seen" setting to "disable", go back to the device exposes tab and click the refresh, the data will adjust to what's in the switch.

Zigbee2MQTT version

1.30.1

Adapter firmware version

20221226

Adapter

SONOFF Zigbee 3.0 USB Dongle Plus ZBDongle-P

Debug log

No response

ZetaWaves commented 1 year ago

I am experiencing the same problem. It causes Z2M to constantly send payloads requesting the information that isn't specifically set, even if it's set as default values on the switch itself. This needs fixed ASAP.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

ZetaWaves commented 1 year ago

Bump. Still a problem.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

mbrink123 commented 1 year ago

It's still needed.

On Sun, May 7, 2023, 5:02 PM github-actions[bot] @.***> wrote:

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1537574792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDA35PWQPDFW4JGT32LXFAZZPANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

mbrink123 commented 1 year ago

It is still an issue.

On Thu, Jun 8, 2023, 5:03 PM github-actions[bot] @.***> wrote:

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1583630812, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDHL662ZM35ZF3TFVXTXKJR3VANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

bradsjm commented 1 year ago

Bump, same issue.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

mbrink123 commented 1 year ago

It still needs fixed

On Mon, Jul 17, 2023 at 5:03 PM github-actions[bot] < @.***> wrote:

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1639057295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDFLKVJGO376OJME333XQXHEFANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

mbrink123 commented 1 year ago

Unstale

On Fri, Aug 18, 2023, 5:02 PM github-actions[bot] @.***> wrote:

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1684561397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDESQI22FDWQUO6S773XV77ADANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

Koenkk commented 1 year ago

Can you provide the debug log of this?

See https://www.zigbee2mqtt.io/guide/usage/debug.html on how to enable debug logging.

mbrink123 commented 1 year ago

I think this is what your looking for.

On Fri, Aug 18, 2023 at 11:46 PM Koen Kanters @.***> wrote:

Can you provide the debug log of this?

See https://www.zigbee2mqtt.io/guide/usage/debug.html on how to enable debug logging.

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1684863671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDGKW2WBNARL63OQSULXWBOLXANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

mbrink123 commented 1 year ago

Unstale

On Thu, Sep 21, 2023, 5:02 PM github-actions[bot] @.***> wrote:

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

— Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1730511938, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXH3PDF3LZJ2V7OAXGAJCULX3TIRXANCNFSM6AAAAAAUXIDUTU . You are receiving this because you authored the thread.Message ID: @.***>

Koenkk commented 1 year ago

I don't see any log file in https://github.com/Koenkk/zigbee2mqtt/issues/16609#issuecomment-1688705489

mbrink123 commented 1 year ago

I guess email replies dont attach attachments. Lets try again. 45df7312_zigbee2mqtt_2023-08-22T18-26-06.181Z(1).log

Koenkk commented 1 year ago

I see the log level is not set to debug, also can you make sure you reproduce the issue in the log?

Change the "last seen" setting in Z2M (settings--advanced--last seen) to ISO_8601_local, add a new inovelli switch to Z2M, go to the device page for that switch, goto the exposes tab, scroll down to any setting that is blank and click the refresh button (nothing will happen). Go back into settings and set the "last seen" setting to "disable", go back to the device exposes tab and click the refresh, the data will adjust to what's in the switch.

See https://www.zigbee2mqtt.io/guide/usage/debug.html on how to enable debug logging.

mbrink123 commented 1 year ago

this work? Look at office light switch at the very end of the log. 45df7312_zigbee2mqtt_2023-09-27T18-27-18.462Z.log

Koenkk commented 1 year ago

I don't see you doing this in the log:

scroll down to any setting that is blank and click the refresh button (nothing will happen)

I expect to see a zigbee2mqtt/Office Light Switch/get in the log.

raineth commented 1 year ago

Here are 2 requests:

debug 2023-10-05 04:28:27: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"ledIntensityWhenOff":""}'
debug 2023-10-05 04:28:27: Publishing get 'get' 'ledIntensityWhenOff' to 'Master Bedroom Light'
debug 2023-10-05 04:28:27: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"ledIntensityWhenOff":1}' from endpoint 1 with groupID 0
info  2023-10-05 04:28:27: MQTT publish: topic 'zigbee2mqtt/Master Bedroom Light', payload '{[...TRIMMED...],"last_seen":"2023-10-05T04:28:27-04:00",[...TRIMMED...],"ledIntensityWhenOff":null,[...TRIMMED...]}'
debug 2023-10-05 04:28:42: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"ledIntensityWhenOff":""}'
debug 2023-10-05 04:28:42: Publishing get 'get' 'ledIntensityWhenOff' to 'Master Bedroom Light'
debug 2023-10-05 04:28:42: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"ledIntensityWhenOff":1}' from endpoint 1 with groupID 0
info  2023-10-05 04:28:42: MQTT publish: topic 'zigbee2mqtt/Master Bedroom Light', payload '{[...TRIMMED...],"last_seen":"2023-10-05T04:28:42-04:00",[...TRIMMED...],"ledIntensityWhenOff":null,[...TRIMMED...]}'

Untrimmed log messages attached.

Koenkk commented 1 year ago

@raineth I see that the state is published correctly. Can you provide a debug log of the following:

raineth commented 1 year ago

I'm seeing the inverse of your expectation. For clarity, I removed the cached state for the attribute I'm testing with (ledIntensityWhenOff) and restarted zigbee2mqtt before doing this test.

debug 2023-10-05 15:37:27: Received MQTT message on 'zigbee2mqtt/bridge/request/options' with data '{"options":{"advanced":{[...],"last_seen":"disable",[...]}},"transaction":"h2hzx-1"}'
info  2023-10-05 15:37:27: Successfully changed options
info  2023-10-05 15:37:27: MQTT publish: topic 'zigbee2mqtt/bridge/response/options', payload '{"data":{"restart_required":false},"status":"ok","transaction":"h2hzx-1"}'
debug 2023-10-05 15:37:38: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"ledIntensityWhenOff":""}'
debug 2023-10-05 15:37:38: Publishing get 'get' 'ledIntensityWhenOff' to 'Master Bedroom Light'
debug 2023-10-05 15:37:39: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"ledIntensityWhenOff":1}' from endpoint 1 with groupID 0
debug 2023-10-05 15:38:10: Received MQTT message on 'zigbee2mqtt/bridge/request/options' with data '{"options":{"advanced":{[...],"last_seen":"ISO_8601_local",[...]}},"transaction":"h2hzx-2"}'
info  2023-10-05 15:38:10: Successfully changed options
info  2023-10-05 15:38:10: MQTT publish: topic 'zigbee2mqtt/bridge/response/options', payload '{"data":{"restart_required":false},"status":"ok","transaction":"h2hzx-2"}'
debug 2023-10-05 15:38:14: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"ledIntensityWhenOff":""}'
debug 2023-10-05 15:38:14: Publishing get 'get' 'ledIntensityWhenOff' to 'Master Bedroom Light'
debug 2023-10-05 15:38:14: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"ledIntensityWhenOff":1}' from endpoint 1 with groupID 0
info  2023-10-05 15:38:14: MQTT publish: topic 'zigbee2mqtt/Master Bedroom Light', payload '{[...]"last_seen":"2023-10-05T15:38:14-04:00",[...],"ledIntensityWhenOff":1,[...]}'

Full log

After doing the first get, the web UI didn't update automatically, but the value was present when I reloaded the page.

Koenkk commented 1 year ago

@raineth can you provide the contents of you data/configuration.yaml (without passwords/ips in it)

raineth commented 1 year ago

@Koenkk Sure, here's my redacted configuration.yaml

Koenkk commented 1 year ago

@raineth pushed a fix

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

raineth commented 1 year ago

I'm at HEAD for zigbee2mqtt. I tried updating my package.json to bump the version of zigbee-herdsman-converters to 15.91.0, ran npm install/ci, but zigbee2mqtt doesn't start:

> zigbee2mqtt@1.33.1 start
> node index.js

Error: Cannot find module '/srv/zigbee2mqtt/node_modules/zigbee-herdsman-converters/index.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:409:19)
    at Function.Module._findPath (node:internal/modules/cjs/loader:651:18)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1025:27)
    at Function.Module._load (node:internal/modules/cjs/loader:885:27)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/srv/zigbee2mqtt/lib/model/device.ts:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)

It's possible I've missed a step, I haven't done any serious NodeJS development.

Koenkk commented 1 year ago

Don't do any manual changes, instead execute npm install zigbee-herdsman-converters@15.92.1

raineth commented 1 year ago

Cool, that worked! Refreshing integer settings now works properly and updates the UI as soon as the Zigbee response is received.

I tried refreshing other values, and I discovered that changing non-integer settings seems to be broken now regardless of the last_seen setting. It seems that such values are no longer mapped from integers to their names.

Some examples:

I tried downgrading zigbee-herdsman-converters back to 15.86.1 and was able to refresh those values if last_seen was disabled, although they didn't update in the UI until I reloaded the page.

15.92.1

debug 2023-10-11 16:34:36: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"powerType":""}'
debug 2023-10-11 16:34:36: Publishing get 'get' 'powerType' to 'Master Bedroom Light'
debug 2023-10-11 16:34:36: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"powerType":1}' from endpoint 1 with groupID 0
info  2023-10-11 16:34:36: MQTT publish: topic 'zigbee2mqtt/Master Bedroom Light', payload '{...,"powerType":1,...}'

vs.

15.86.1

debug 2023-10-11 16:15:16: Received MQTT message on 'zigbee2mqtt/Master Bedroom Light/get' with data '{"powerType":""}'
debug 2023-10-11 16:15:16: Publishing get 'get' 'powerType' to 'Master Bedroom Light'
debug 2023-10-11 16:15:16: Received Zigbee message from 'Master Bedroom Light', type 'readResponse', cluster 'manuSpecificInovelliVZM31SN', data '{"powerType":1}' from endpoint 1 with groupID 0
info  2023-10-11 16:18:05: MQTT publish: topic 'zigbee2mqtt/Master Bedroom Light', payload '{...,"powerType":"Neutral",...}'
Koenkk commented 1 year ago

Should be fixed now

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

raineth commented 1 year ago

Everything seems to be working properly with zigbee-herdsman-converters@15.93.0, thank you!

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days