Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge πŸŒ‰, get rid of your proprietary Zigbee bridges πŸ”¨
https://www.zigbee2mqtt.io
GNU General Public License v3.0
11.75k stars 1.64k forks source link

ELKO 4523430 (ESH Plus Super TR RF PH) sends update to z2m every second. #18619

Closed glennher closed 10 months ago

glennher commented 1 year ago

What happened?

I have a network with about 12 thermostates, and with with all of them updating the system every second they flood the adapter and after a while make it crash. When this happends the only solution so far is to unplug the usb adapter and replug it again and restart zigbee2mqtt.

Reference to same issue that is closed without any solutions:

16142

What did you expect to happen?

How to reproduce it (minimal and precise)

Connect a device and look at the logs, try to adjust minimum report interval and see if reporting changes.

Zigbee2MQTT version

1.32.2-1

Adapter firmware version

CC2652R_coordinator_20230507

Adapter

Electrolama zzh CC2652

Debug log

No response

github-actions[bot] commented 12 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

arnerek commented 12 months ago

Anyone found the reason for this?

glennher commented 12 months ago

I suspect the root cause might be related to the thermostat firmware rather than the adapter. I have thermostats with firmware versions 1.2.0R and 1.2.4R that exhibit this flooding behavior. However, a new thermostat with firmware version 1.2.5R does not seem to have this issue. I've reached out to Elko support to inquire about firmware updates for the thermostats but have not received any response yet.

arnerek commented 12 months ago

That’s interesting. I have 1.2.5R on two devices and experience the flooding unless I comment the subscription code.

tor. 14. sep. 2023 kl. 19:37 skrev Glenn Hermansen @.***

:

I suspect the root cause might be related to the thermostat firmware rather than the adapter. I have thermostats with firmware versions 1.2.0R and 1.2.4R that exhibit this flooding behavior. However, a new thermostat with firmware version 1.2.5R does not seem to have this issue. I've reached out to Elko support to inquire about firmware updates for the thermostats but have not received any response yet.

β€” Reply to this email directly, view it on GitHub https://github.com/Koenkk/zigbee2mqtt/issues/18619#issuecomment-1719874831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCP6G455C2CICETYQKTPGLX2M6G3ANCNFSM6AAAAAA3QLH2KI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

arnerek commented 10 months ago

I checked in the dev console: Could this shed some light?

I think the attributes are incorrectly converted to a number?

image
glennher commented 10 months ago

I think you are on to something.

In the reporting section of the device, the 1025 attribute cannot be controlled or changed intervals on (you get an error that it does not exist/is undefined). However if you change the 1025 attribute to the corresponding "elkoLoad" instead, you are able to control the timers again, and then you can try to set "min rep interval" to 60 seconds and apply. It will now report only once per minute.

arnerek commented 10 months ago

I finally managed to progress here: 1) To get the reporting every second to disappear, set reportableChange to 1 in https://github.com/Koenkk/zigbee-herdsman-converters/blob/06ff10bd56b50e402ecd51740df9d5cfbc5ffc99/src/devices/elko.ts#L97 2) The Elko attributes are not recognized in the reporting section, e.g. elkoLoad is mapped directly to 1025. If I remove the manufacturerCode: manufacturerCode_1.default.ELKO from https://github.com/Koenkk/zigbee-herdsman/blob/4a929684f58eb1e57b998f9cae0da8420dafce32/src/zcl/definition/cluster.ts#L2040 - all is good! I don't know if this has side-effects for other devices, but at least it is working for me

Compared to without these changes (https://github.com/Koenkk/zigbee2mqtt/issues/16142#issuecomment-1407479874) this is what I get now: image