French fil pilote/pilot wire: refactoring to bringing coherence and standardisation

[esciara]

What happened?

Related to #19169.

I create this issue as a "problem" issue as the better fitting type, even though this ticket is a refactoring proposal.

Various devices support the French fil pilote standard (translated commonly as pilot wire) for radiators, but they do so by using different terms, bringing inconsistency and confusion.

To give a few examples:

• terms are translated differently from one implementation to another (for instance "hors gel" and "arrêt" are translated as frost_protection and off here but anti-freeze and stop there).
• French words are sometimes translated, some times not (for instance "fil pilote" is translated here or here but not there or there).
• There is no "pilot wire" predefined preset, so anyone wanting to implement a pilot wire device:
  1. Is left to its own choice of potential new words describing an existing and well established standard.
  2. Has the pilot entity showed as a select entity in Home Assistant (I guess it could be similar on other home automation applications), which is a bit confusing. (will add screenshots later).

What did you expect to happen?

I suggest that the following rules are followed as part of a refactoring:

• Language and translations:
  • Variables are to be in english (e.g.: nodon_pilot_wire_mode and not nodon_fil_pilote_mode).
  • Translations in general are correct ("proper" as usually called) english translations (not "franglish").
  • If there are several potentially correct translations, words most commonly used in the rest of the code are reused.
• In variables and values, words are to be separated with _ underscores (e.g: comfort_-1 and not comfort-1).
• A pilot_wire_mode preset is created and used by the existing pilot wire devices (today Legrand and Nodon/Adeo)with the following values:
  • comfort
  • eco
  • frost_protection
  • off
  • comfort_-1 (put at the end as less commonly used)
  • comfort_-2 (put at the end as less commonly used)

How to reproduce it (minimal and precise)

N/A

Zigbee2MQTT version

1.34.0

Adapter firmware version

N/A

Adapter

N/A

Debug log

No response

[github-actions[bot]]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days