Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge 🌉, get rid of your proprietary Zigbee bridges 🔨
https://www.zigbee2mqtt.io
GNU General Public License v3.0
12.08k stars 1.68k forks source link

Errors after upgrade to 1.35.0 for _TZE200_rtrmfadk: Publish 'set' 'preset' to 'REMOVED DEVICE NAME' failed: 'Error: No datapoint defined for 'preset'' #20476

Closed Da-Hermit closed 10 months ago

Da-Hermit commented 10 months ago

What happened?

Following update to version 1.35.0 where the TRV _TZE200_rtrmfadk was now being configured as a TRV602 instead of TRV601, I am getting the following errors when trying to change 'preset'.

Error 2024-01-01 15:48:03Publish 'set' 'preset' to 'DEVICE NAME REMOVED' failed: 'Error: No datapoint defined for 'preset''

Devices show up as TS602 and link to correct page/photo.

What did you expect to happen?

Expected features available to be corrected

How to reproduce it (minimal and precise)

Attempt to change Preset value in frontend or from HomeAssistant.

Zigbee2MQTT version

1.35.0

Adapter firmware version

7.3.1.0 build 176

Adapter

EZSP v12

Debug log

zblog.txt

ASNNetworks commented 10 months ago

Same for this radiator valve: TS0601 TZE200_z1tyspqw: https://www.zigbee2mqtt.io/devices/GTZ06.html

I have three of these and none now can set any thing anymore. Presets give the same error as mentioned above. So also can't select manual preset to change temperature.

Tried deleting and pairing device, no luck.

Z2M 1.35.0, using Sonoff P dongle.

Da-Hermit commented 10 months ago

I have resorted to using an old external converter which fixed the issue but it doesn't include all the features the new release had.

PrzemsiMat commented 10 months ago

the same issue for [TRV602] and [GTZ06] can not change preset in HA, but when i switch preset on device using encoder switch, z2m show correct

Koenkk commented 10 months ago

Setting the preset is not supported indeed, @lompi could you take a look at this?

lompi commented 10 months ago

@Koenkk works correctly before extracting part of the code related to preset and system_mode. So the problem is in the data converter. As I told in my PR, js is not my technology, so I may made mistake on this small refactor.

Koenkk commented 10 months ago

Could you check if the issue is fixed with the following external converter:

PrzemsiMat commented 10 months ago

2024-01-03 10:37:58Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'on'' 2024-01-03 10:38:15Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'off'' 2024-01-03 10:38:22Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'on'' 2024-01-03 10:38:29Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'off'' 2024-01-03 10:38:36Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'manual'' 2024-01-03 10:38:41Publish 'set' 'preset' to 'Głowica Salon' failed: 'Error: Expected one of: 0, 1, 2, 3, got: 'off''

Koenkk commented 10 months ago

Updated https://gist.github.com/Koenkk/388387067ac18ba01369dfb898b72a2b

PrzemsiMat commented 10 months ago

Preset change sucsesfull but something is not ok. Before update when i set off , TRV LCD display OFF (valve set 0% ), when i set on - LCD display ON (valve set 100%), and now presets are changed but TRV acts like in Auto mode

lompi commented 10 months ago

@PrzemsiMat With these changes, the preset changes but the system_mode does not change. Currently working on a fix.

lompi commented 10 months ago

I created PR to fix this problem https://github.com/Koenkk/zigbee-herdsman-converters/pull/6819.

PrzemsiMat commented 10 months ago

thx, grate job

Koenkk commented 10 months ago

Fixed, thanks @lompi

Changes will be available in the dev branch tomorrow

pawol commented 10 months ago

Probably I reported similar issue there: https://github.com/Koenkk/zigbee2mqtt/issues/20598