TuYa BSD29_1: Updates to measurement polling interval require a restart to apply

nARN commented 9 months ago

What happened?

Following up on #21018. Similarly to the @felipebraz I found it confusing that changing measurement poll interval does not affect the frequency of updates until Z2M is restarted.

It seems to only be necessary when polling is initially enabled. When polling interval is set to -1 the next change applies without restarting.

What did you expect to happen?

Either polling interval should apply right away, or, if the restart requirement is intentional, it should be documented (ideally in the UI itself, in addition to the device doc)

How to reproduce it (minimal and precise)

On the "Settings (specific)" tab of a TuYa BSD29_1, ensure that measurement poll interval is not -1 (the default of 60 seconds is ok)
Set measurement poll interval to a new value
Observe update frequency on the corresponding topic. It will be the previous update frequency
Restart zigbee2mqtt
Observe update frequency on the corresponding topic. It will be the new frequency.

To confirm that updates apply without restarting when polling is disabled:

set poll interval to -1
restart zigbee2mqtt (to apply the change)
set poll interval to a new positive value
Observe that updates are now coming through without a restart

Zigbee2MQTT version

1.35.1

Adapter firmware version

20210708

Adapter

Sonoff ZBDongle-P

Setup

RPi, RasPiOS bullseye arm64, systemd

Debug log

No response

redpixy commented 9 months ago

Yes, I also realised this, the settings doesn't get updated until z2m is restarted.

klelifo commented 8 months ago

Same here (using HomeAssistant). Changed the setting for the polling interval and it did not become active until I restarted zigbee2mqtt. You can easily verify that the setting is applied (or not) by filtering for the relevant messages in the "Log" tab of Homeassistant.

verybadsoldier commented 5 months ago

I can confirm z2m needs a restart after changing the polling setting to make it effective.

ZionFox commented 4 months ago

Can confirm as of 1.39.0 it still requires a restart of Z2M for the changes to take effect.

If this isn't intended to be implemented any time soon, perhaps it's wise to inform the users in the description to measurement_poll_interval to instruct them to restart Z2M for changes to take effect?

rolandas-valantinas commented 1 month ago

Still problem on 1.40.0! Spent hours trying to figure out why my TS011F is not updating with correct power figures, thought it was a faulty plug. When stumbled upon this issue, restarted Z2M and plug now polling at correct intervals.

ericcastro commented 3 weeks ago

confirm this problem is still present as of october 2024

Koenkk / zigbee2mqtt