Can't generate helm releases with '+' in the version.

Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge 🌉, get rid of your proprietary Zigbee bridges 🔨

https://www.zigbee2mqtt.io

GNU General Public License v3.0

11.3k stars 1.61k forks source link

Can't generate helm releases with '+' in the version. #22561

Open jlpedrosa opened 1 month ago

jlpedrosa commented 1 month ago

What happened?

This is just a heads up. The current version of helm releases fails to run the helm release chart process if the version contains a '+' simbol (which is a valid sem versioning).

I tracked down the problem an open a PR to fix it, they don't seem very responsive: https://github.com/helm/chart-releaser/pull/406

Charts with '-' symbols work ok in the interim.

What did you expect to happen?

Not a zigbee2mqtt issue.

How to reproduce it (minimal and precise)

Not a zigbee2mqtt issue.

Zigbee2MQTT version

1.37.0

Adapter firmware version

20230507

Adapter

any

Setup

any

Debug log

Koenkk commented 1 month ago

There was also a mistake in the branch name, fixed it in https://github.com/Koenkk/zigbee2mqtt/commit/34f0332564b91c0d866a667233caefa4c6da911c

I guess we should hold back https://github.com/Koenkk/zigbee2mqtt.io/pull/2738 for now?

jlpedrosa commented 1 month ago

I don't think is a problem with the cadence of releases that you have (I don't think we well need to release hot fixes). Imo is fine, I'm just tracking the issue here, and let you know.

I think we can merge https://github.com/Koenkk/zigbee2mqtt.io/pull/2743 as soon as the release is done and I've done some testing to validate.

jlpedrosa commented 1 month ago

If possible, I'd do a PR to enable the workflow release of the helm chart via "click" on the UI and ask you to trigger it if you are up to it.

Koenkk commented 1 month ago

@jlpedrosa can you check if the chart is published, then I can merge https://github.com/Koenkk/zigbee2mqtt.io/pull/2743