Koenkk / zigbee2mqtt

Zigbee 🐝 to MQTT bridge πŸŒ‰, get rid of your proprietary Zigbee bridges πŸ”¨
https://www.zigbee2mqtt.io
GNU General Public License v3.0
12k stars 1.67k forks source link

zigbee2mqtt unreliable: queuing is wrong #842

Closed henriz closed 5 years ago

henriz commented 5 years ago

Hello,

I'd like to get in to the development of this plugin, to help improve it.

At it's current state, in my opninion, it's unreliable. It works for about half a day, and then starts acting up. And when it works, there's something wrong in the queing mechanism. In situations with multiple commands, it somehow seems to get clogged with commands.

This results in it doing nothing for a certain amount of times, and then all the sudden process the queue of commands. I understand there has been a change recently for situations with multiple commands, I think something went wrong there?

I'm using hue dimmer switches which are controlling multiple devices. I haven't used the new grouping functionality for that yet, so one button press results in multiple commands. These commands are being sent, so on the domoticz/nodered side of things, it's working fine. I can see the commands being sent.

Set level always works fine. So the dimmer functionality always works fine, but as soon as I want to change scene, and do that multiple times in a row, it clogs up, and this can easily take like 40 seconds to a minute. I have children who then keep on pressing the buttons, which results in, when it picks up again, a discoshow for like 2 minutes, when it is 'replaying' the list of commands.

I haven't really looked into the code yet, but it feels to me like this app needs threading.

Also what I've noticed; when started the first time, on/off commands for lights do not work. First you have to set a level, which does work, before on/off commands to work. In general on/of does not work very wel, set level works way better.

Are you open to have other devvers join?