search

Koenvh1 / ets2-local-radio

Radio from wherever you are in ETS2/ATS
https://koenvh.nl/projects/ets2-local-radio
Mozilla Public License 2.0
234 stars 40 forks source link

Update stations Road to Asia, Red Sea Map, Viva Malta, Project Greenland #161

Closed keremguvercin closed 2 years ago

rafaelkai commented 3 years ago

You might want to add the image files locally, URLs can change

Koenvh1 commented 3 years ago

Please add the images for the stations locally. Links don't last forever, and with several thousand stations you are hunting broken links daily.

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
| Secret | Commit | Filename | Detected At | | | ------------------------- | ---------------- | --------------- | -------------------- | -------------------- | | Generic High Entropy Secret | e4d436e13824e219a86dd3eff7b09ad6d0798852 | web/stations/stations-europe.js | 12:57 January 17th, 2022 | [View secret](https://github.com/Koenvh1/ets2-local-radio/commit/e4d436e13824e219a86dd3eff7b09ad6d0798852#diff-f74fadc19577fececda4d4e690247888L2317) | | Generic High Entropy Secret | fe945f41bafa67641fe2b98a344dc050bc9d89e8 | web/stations/stations-europe.js | 12:57 January 17th, 2022 | [View secret](https://github.com/Koenvh1/ets2-local-radio/commit/fe945f41bafa67641fe2b98a344dc050bc9d89e8#diff-f74fadc19577fececda4d4e690247888R2317) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks
rafaelkai commented 2 years ago

Please add the images for the stations locally. Links don't last forever, and with several thousand stations you are hunting broken links daily.

He has already added the images locally in #171 Total of his work would be: #160 #161 #171

Koenvh1 commented 2 years ago

Merged with #160