KoffeinFlummi / AGM_Compatibility

Compatibility PBOs for AGM
Other
7 stars 2 forks source link

Community Upgrade Project #5

Closed bux closed 9 years ago

bux commented 9 years ago

State: Golden 9/10



- [ ] Improve backblast - [ ] audibleFire values (this is something they should do themselves though)


http://forums.bistudio.com/showthread.php?169933-Community-Upgrade-Project

Dslyecxi on CUP Weapons: https://www.youtube.com/watch?v=_AFebIotSOE

nicolasbadano commented 9 years ago

I've contacted kju to let them know we would be probably doing this (in case they want to help, or add the compat entries directly within CUP). I also asked for their thoughs about https://github.com/KoffeinFlummi/AGM/issues/1287.

Trigger81 commented 9 years ago

CUP is released ;) yeah

nicolasbadano commented 9 years ago

Started with the compat pbo. Done for now are

nicolasbadano commented 9 years ago
KoffeinFlummi commented 9 years ago
lubomirblazekcz commented 9 years ago

I wanted to do conifg for disposable, but this will be better as separate pbo I guess. Ideas?

nicolasbadano commented 9 years ago

I wanted to do conifg for disposable, but this will be better as separate pbo I guess. Ideas?

Well, probably, as those changes would destroy the launchers if AGM_Disposable is not used. TBH, I'm not sure what's best ATM. Start working on this however you see fit, create a PR and we'll sort it out later.

KoffeinFlummi commented 9 years ago

Well, probably, as those changes would destroy the launchers if AGM_Disposable is not used.

I'm not sure that's the case. I think the only side effect would be another used launcher in the VA that serves no purpose.

lubomirblazekcz commented 9 years ago

Well used launcher should have scope = 1; and problem solved then

KoffeinFlummi commented 9 years ago

In that case, there shouldn't be any problems at all.

nicolasbadano commented 9 years ago

I'm not sure that's the case. I think the only side effect would be another used launcher in the VA that serves no purpose.

There's one additional side effect:

Currently, the way disposable config is made causes the launchers to be loaded by default with an AGM_PreloadedMissileDummy, which has an invisible icon. If AGM_Disposable is not loaded, this dummies could be removed from the weapon, which would look weird, having a dummy missile laying around.

Maybe we should remove the dummies altogether. Looking at the code, I think the only reason they were introduced is for the rocket icon not to show as loaded in the launcher, which I personally don't think it's necesary. Furthermore, it seems that we are even hiding the secondary weapon magazine inventory slot to prevent unloading of dummy magazines, so the icon wouldn't show anyway.

@commy2, what aare your thoughts on this? Am I missing something?

lubomirblazekcz commented 9 years ago

Any plans on adding agm compatible magazines? eg. AGM_30Rnd_65x39_caseless_mag_SD and other 5.56

simonamdev commented 9 years ago

I submitted a pull request a few minutes ago for Javelin top down attack. I've also done backblast and disposable for the rest of the launchers (where applicable) and once I get them sanity checked i'll submit two more pull requests.

Ref: #32

Cyruz143 commented 9 years ago

CUP pushed all of these in to the base configs bar the disposables, might want to remove the redundant ones to avoid confusion now!

kripto202 commented 9 years ago

if i remember right the disposable rocket launcher is already in rhs

simonamdev commented 9 years ago

RHS and CUP are two separate packs though. If someone wants to run the RHS disposable they can just not include the CUP AGM compatibility patch.