Modularity

[jonpas]

• [x] HLC
• [x] CUP
• [ ] BWA3 (?)

---

All HLC and CUP modules (PBOs) are under requiredAddons in their respective compatibility PBOs.. What if someone is not using all of modules of the mod and still wants AGM Compatibility?

The only way out of it would be more compatibility PBOs, one for each mod's PBO, to keep the modularity even with AGM Compatibility. It looks like CUP has it's own PBO for ammo, not sure about HLC HLC's ammo is in the weapon's PBO, the classname always ends with that weapon's name though, easy to find..

I can help out if that's something that you maybe want, with the nice comments where fits what that you put down, it's just slightly time-consuming.

[nicolasbadano]

All HLC and CUP modules (PBOs) are under requiredAddons in their respective compatibility PBOs.. What if someone is not using all of modules of the mod and still wants AGM Compatibility?

Yep, I'm aware of this inconvenience. Of course keeping full modularity would be great, but there's really no simple way of doing it except by splitting the compatilibty PBO as you say. Basically one comp PBO per original PBO. That offloads the complexity of selecting which pbos to use to the end user, which is not ideal either; at least not without very detailed instructions on what to do.

Just for CUP, we would currently require 19 pbos to keep the modularity!!

Of course we could try to come up with something revolutionary that selects pbos automatically or something, but don't count on that.

So, IDK...

[nicolasbadano]

It looks like CUP has it's own PBO for ammo, not sure about HLC HLC's ammo is in the weapon's PBO, the classname always ends with that weapon's name though, easy to find..

Actually both have an ammo pbo. That would cover the bullet mass entries very nicely. But I do need the weapon pbos to be required in order to configure the bipods, reliability, jam chance, etc. The simple option to keep that modular would be to have one comp pbo per weapon pbo. But that's a lot of pbos.

[jonpas]

Yes it would be a lot of pbos... But if it's something we might want to do, I can help out with splitting it. Also if we do this, sub-folder is needed not to cramp everything else up in the project.

[jonpas]

Agreed this should be done?

[nicolasbadano]

Yes El 14/12/2014 14:16, "jonpas" notifications@github.com escribió:

Agreed this should be done?

— Reply to this email directly or view it on GitHub https://github.com/KoffeinFlummi/AGM_Compatibility/issues/7#issuecomment-66920243 .

[jonpas]

Did something #9

[jonpas]

Not sure if it's worth splitting CUP, didn't hear of anyone that uses parts of it yet and also there can be problems when removing some pbos due to the added units with CUP weapons in loadouts and ammoboxes it adds. I tried and for many pbos it gives error "required addon xyz".

I'll fix the formatting soon though.

[nicolasbadano]

I'll fix the formatting soon though.

Regarding formatting, I kept tabs on purpose (heresy!). As I copy pasted the class inheritance from CUP config, I figured it would be easier to maintain if I kept the same whitespaces that they have.

We may change it later, but I don't think it's worth to do it now.

[KoffeinFlummi]

I kept tabs on purpose

[jonpas]

I found something that could be helpful with that @esteldunedain http://stackoverflow.com/questions/455037/notepad-convert-tabs-to-spaces (first reply). That's if you use Notepad++, and you need TextFX Characters plugin (it's in the plugin manager, just have to install it through n++).

I just tried it on CUP and it worked without any issues! If you are ok with it, I will push the update and then when you compare with CUP's file you can use that plugin and then compare.

Also, this plugin should go into Coding Guidelines and Tabler for strings as well, to make it easy for newcomers.

EDIT: TextFX also has tons of other great features, just check the menu!

[bux]

No need for another plugin. "Edit > Blank Operations > TAB to Space"

But I guess ease of converting isn't the reason why he decided to keep tabs :)

[nicolasbadano]

Actually notepad++ can do that without plugins (Edit->Blank Operations->*)

[jonpas]

Oh, heh, 2 answers at once, Didn't know that, still TextFX has other good stuff as well, but thanks for telling me this is actually a 'vanilla' thing as well.

But I guess ease of converting isn't the reason why he decided to keep tabs :)

What is it then?

[nicolasbadano]

Ups, he beat me to it. I kept the same whitespace as CUP figuring it would be usefull for maintainance; but it was actually an almost supersticious decision, as I really can think of any solid reason right now. Change it if you want.

[jonpas]

Always better more answers than one, it truly confirmed my blindness!

I'll push the update, then you guys can decide if you want to please Flummi.

[Cuel]

@jonpass

My group have removed all pistols and AKs from CUP in favor of HLC/RH/RHS

Also had to remove the units, ammoboxes and zeus to make it launch due to dependencies

[jonpas]

So you would benefit from AGM Compatibility CUP being modular as well?

You should be able to use the full CUP Compatibility though, it's just config entries and shouldn't be any problem at all.

[Cuel]

You should be able to use the full CUP Compatibility though, it's just config entries and shouldn't be >any problem at all.

If it'll work out of the box then no, we don't need modularity That sounds good, we're not using it today but I'll be adding stuff to our repo next week.

[jonpas]

There shouldn't be any problems, maybe @esteldunedain can confirm as he wrote the compatibility config.

Make sure you do a test beforehand though and report if you find any issues. ;)

[jonpas]

@Cuel Actually, there will be an issue with it I am afraid. AGM Comp CUP lists all CUP PBOs as requiredAddons, so when you will launch it with some CUP parts removed it will display a message that it requires it. I'll see what I can do for it.

[jonpas]

CUP Modularity in #15

@KoffeinFlummi How modular is BWA3? Can you throw out one of the PBOs and other will still work or are there dependencies over them? I guess vehicles require units, but I bet weapons don't require anything else. Could you maybe write a quick list of requiredAddons of each PBO from BWA3 mod so I can split that up as well if possible?

[Cuel]

Awesome, thanks