search

KoffeinFlummi / AGM_Compatibility

Compatibility PBOs for AGM
Other
7 stars 2 forks source link

HLC Modularity #9

Closed jonpas closed 9 years ago

jonpas commented 9 years ago

Core PBO had ANSI encoding and didn't allow UTF-8 w/o BOM due to some strange * character (not the normal multiplication symbol) in magazine names in some comments, replaced those with x.

Should AGM_Comp_HLC_Core be in requiredAddons of every weapon? This hasn't been tested yet either.

bux commented 9 years ago

https://github.com/KoffeinFlummi/AGM/wiki/Coding-Guidelines :smile: Might not be your fault, but if you're already at it, could you reformat the files?

jonpas commented 9 years ago

Ahh, I took what @esteldunedain did and just split it. <.< Fixing now.

nicolasbadano commented 9 years ago

Ahh, I took what @esteldunedain did and just split it. <.< Fixing now.

Those comments were copy pasted from toadie. I didn't realize that character was not actually an x

BTW, great job

jonpas commented 9 years ago

Should AGM_Comp_HLC_Core be in requiredAddons of every weapon?

nicolasbadano commented 9 years ago

Should AGM_Comp_HLC_Core be in requiredAddons of every weapon?

Yes, I think so. It doesn't break anything even if you don't want to use AGM_Overheating, so there's no problem on requiring it.

jonpas commented 9 years ago

Perfect, just needs testing then in case I missed something.

jonpas commented 9 years ago

I'll test this tomorrow. Should I add myself to authors in the PBOs? I didn't really "add" anything... (maybe someone can blame me then when something doesn't work, haha).

nicolasbadano commented 9 years ago

Of course, add yourself as author.

jonpas commented 9 years ago

When testing I noticed it can't be in subfolder for binarizer to pick up correctly. How should I go about this, just drop all folders into root of the repo?

nicolasbadano commented 9 years ago

When testing I noticed it can't be in subfolder for binarizer to pick up correctly. How should I go about this, just drop all folders into root of the repo?

No, I think we should keep every pbo for a given addon inside the same folder. We can modify the binarizer to look for that

KoffeinFlummi commented 9 years ago

No, I think we should keep every pbo for a given addon inside the same folder. We can modify the binarizer to look for that

...

We can modify the binarizer to look for that

...

We

nicolasbadano commented 9 years ago

:smile: You bastard! I'll get my dirty hands in your little pretty binarizer if necesary. Believe me, it won't be pretty; I'll even replace spaces by tabs.

KoffeinFlummi commented 9 years ago

Made a ticket for that over in the main repo: KoffeinFlummi/AGM#1921