KoffeinFlummi / armake2

Successor to armake written in Rust
GNU General Public License v2.0
50 stars 17 forks source link

Version number in PBOPREFIX causes runtime issues #20

Closed bovine3dom closed 5 years ago

bovine3dom commented 5 years ago

I'm dealing with an old mod pack which has a few PBOPREFIX files of the form

z\LSR\addons\equipment_backpack
version = 65170629⏎

This doesn't cause any build-time errors, but at runtime, certain objects can't be found:

Relevant part of RPT:

17:51:16 Warning Message: Cannot load texture z\lsr\addons\equipment_backpack\ui\gear_16aa_backpack_daysack_ca.paa.
17:51:16 Warning Message: Cannot load texture z\lsr\addons\equipment_backpack\ui\gear_16aa_backpack_daysack_ca.paa.
17:51:16 Warning Message: Cannot open object z\lsr\addons\equipment_backpack\16aa_backpack_daysack_10.p3d

I'm not sure what the version string is from or is for, but could you either ignore it or emit an error at build time?

Thanks.

jonpas commented 5 years ago

It is a header extension that seems like is just taken as a long pboprefix with a newline in it.

Either ignore anything after newline or support header extensions from PBOPREFIX file.

Krzmbrzl commented 5 years ago

Actually we do support header extensions. https://github.com/KoffeinFlummi/armake2/blob/5e4aa605929ee092635ce2599519511842ac4e9c/src/pbo.rs#L152 So this appears to be a bug. Do you happen to get this error on windows @bovine3dom?

bovine3dom commented 5 years ago

Yup. Linux untested.

Krzmbrzl commented 5 years ago

Then I guess this is the same bug as #8 and might be fixed with #9

jonpas commented 5 years ago

@bovine3dom tested with #9 AppVeyor build, works correctly and header extension is visible in PBO. :ok_hand:

Krzmbrzl commented 5 years ago

Perfect - should we close this issue as a duplicate then? Hopefully KoffeinFlummi will have the time to merge the PR soon so this problem won't come up anymore ^^

bovine3dom commented 5 years ago

Yeah, closing as duplicate of #8. It even works in game.

jonpas commented 5 years ago

Merged, he can complain to me now. :D