KoffeinFlummi / armake2

Successor to armake written in Rust
GNU General Public License v2.0
50 stars 17 forks source link

Restructure #50

Open BrettMayson opened 5 years ago

BrettMayson commented 5 years ago

This turns armake2 into a proper Rust library.

It is still missing a few small things from master but is ready for testing and any suggested tweaks

Notes signing is now a feature, meaning armake2 can be used without openssl.

jonpas commented 5 years ago

CI is failing build.

BrettMayson commented 5 years ago

The tests have not been modified yet, I mainly need people to test the restructure and suggest any changes they want to see since I rarely use armake2 personally

KoffeinFlummi commented 5 years ago

It's very hard to comment on this PR as a whole since it contains so many changes in a single commit, so it would probably be easier to split this up into multiple PRs.

On some of the actual changes:

BrettMayson commented 5 years ago

probably be easier to split this up into multiple PRs.

This changes so much that might not be possible. Separate issues could be used to discuss different parts of the restructure

BrettMayson commented 5 years ago

There really needs to be a confirm button for closing a PR

publication of the cmd_* functions

I'm fine with those not being public, they were basically all that was public in master so I left them public

KoffeinFlummi commented 5 years ago

I believe they were originally marked as pub for some technical reason, although I could be misremembering. I got the impression that you were intending to make the commands more of a "proper" part of the library with the Command trait, but I guess I was mistaken and it was mostly for clap/the signature feature.

I'll try to play around with some of the changes myself this week; I might try to seperate some changes for overview.