search

KohGuanZeh / pe

0 stars 0 forks source link

Incorrect use of enums in sequence diagram #10

Open KohGuanZeh opened 2 months ago

KohGuanZeh commented 2 months ago

Enumeration is treated as a class when it should instead be a value.

image.png

An enumeration should not be instantiated.

nus-pe-bot commented 2 months ago

Team's Response

Thank you for the report, but we believe the sequence diagram is correct. In Java, enums are classes. Our application makes a call to the static Enum::valueOf method, hence the distinction between the CommandType and type:CommandType.

Morever, this has been supported by Prof Damith in https://github.com/nus-cs2103-AY2324S2/forum/issues/570.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]