search

KohGuanZeh / pe

0 stars 0 forks source link

Identifying duplicate person by name when phone numbers and email should be unique #5

Open KohGuanZeh opened 2 months ago

KohGuanZeh commented 2 months ago

As of now, commands are rejected when users try to add a duplicate person, which is the person of the same name but many people can share the same name.

However, a person should have unique phone numbers and email as there should only be one such registered information unless it has been deleted. However, no checks are done for duplicate phone numbers and users can possibly enter the same contact information.

While allowing for duplicate names is added in planned enhancement, there is no detailed explanation on how a duplicate person check would be conducted.

Screenshot that shows users who have almost same contact information that should have been unique, but have different names:

image.png

Screenshot when you try to add a person of a completely different identity:

image.png

soc-pe-bot commented 2 months ago

Team's Response

Our DG mentions a plan to improve the duplicate checking for contacts, which includes all fields and not just the name.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The planned enhancement does not state specifically what they are checking but the example leans towards checking for duplicate names (current implemented system) except that it is case insensitive. Enforcing distinct contact would only mean that it checks for duplicates but it does not state how and the example is highly misleading as it did not mention anything about verifying duplicates of other fields.