search

Kohulan / DECIMER-Image_Transformer

DECIMER Image Transformer is a deep-learning-based tool designed for automated recognition of chemical structure images. Leveraging transformer architectures, the model converts chemical images into SMILES strings, enabling the digitization of chemical data from scanned documents, literature, and patents.
MIT License
216 stars 52 forks source link

Move heif to an extra dependency #34

Closed ghost closed 1 year ago

ghost commented 1 year ago

pyheif is difficult to install & poorly supported on windows - several of our team are stuck on old versions because of this dependency and the requirements of our environment.

To resolve this, I'm proposing to move pyheif as an "extra", which will not be installed by default, and can be optionally installed with, e.g

pip install decimer[heif]

OBrink commented 1 year ago

Hey @adhardy,

Thank you for bringing this problem to our attention!

We would prefer to keep the installation as simple as possible for everyone so that DECIMER Image Transformer can be used out of the box without the need to look into installation specifications for different use cases. We have discussed the issue and have decided to replace the pyheif package with pillow-heif. I was able to reproduce the problem with pyheif on a computer with Windows 11 whereas it works nicely with pillow-heif.

@Kohulan will update the repository and the pypi package later today.

Thank you for the report! Otto

ghost commented 1 year ago

I was able to install pillow-heif on windows so looks like that should resolve it! Thanks.