Koka / gettext-rs

GNU Gettext FFI binding for Rust
51 stars 25 forks source link

Fix build failure on clang 16: turn off incompatible-function-pointer-types #115

Open Endle opened 6 months ago

Endle commented 6 months ago

This PR is a workaround for https://github.com/Koka/gettext-rs/issues/114

Endle commented 6 months ago

@Minoru Can you have a review? Thank you

crab2313 commented 2 months ago

This does not work on latest MacOS. The output of clang --version:

❯ clang --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
Endle commented 2 months ago

@crab2313 can you share your log?

crab2313 commented 2 months ago

@crab2313 can you share your log?

Nothing special. Clang of MacOS SDK prints different format of version string. So this implementation simply can't get the version of clang.

Endle commented 2 months ago

Thank you for pointing out! I see why it's failing now. I'll do a quick fix to it later