search

Koka / gettext-rs

GNU Gettext FFI binding for Rust
51 stars 25 forks source link

fix-cross-compilation-issues-with-gettext-0.21-on-mingw: Fix cross-compilation issues with gettext 0.21 when compiling for the MinGW target on Linux #80

Closed marin-m closed 2 years ago

marin-m commented 2 years ago

This pull request aims to fix cross-compilation issues with gettext 0.21 when compiling for the MinGW target on Linux, as I outlined previously in issue #76.

It includes a modified version of the gettext-0.21.tar.xz archive produced after modifying the concerned files and recompressing using the tar Jcvf command, as well as a patch of the concerned modifications produced using the LC_ALL=en_US.UTF8 diff -ur command saved in a gettext-0.21.patch file in the same directory. The original gettext-0.21.tar.xz file was also renamed into an gettext-0.21.orig.tar.xz file.

Minoru commented 2 years ago

Apparently it breaks native Linux builds :(

I'm very hesitant to carry custom patches. I don't know what's to be done about -lc, but the tests can probably be avoided by passing something to make. If you do write patches to GNU gettext, please submit them upstream first; if they're accepted, I'm okay with carrying them with gettext-sys until the next update.