search

Koka / gettext-rs

GNU Gettext FFI binding for Rust
51 stars 25 forks source link

Implemented escaping #83

Closed mks-h closed 2 years ago

mks-h commented 2 years ago

Wrote custom parser that supports escaping of format directives, resolving #72. This also lowered the needed Rust version to 1.51.0, fixing #78.

Behavioral changes:

The rule for malformed escaping is that you won't get a singular brace if it's not escaped. See "partial_escaping" unit-test. I also merged some tests, and reordered tests and definitions of pgettext and npgettext macros, because it was driving me crazy.

Minoru commented 2 years ago

Hey, sorry I haven't reviewed this yet — I'm buried under some IRL stuff and I'm not sure when exactly I'll get to this PR. A week at least, maybe two. Sorry about that!

Minoru commented 2 years ago

Okay, I filed #86, so let me close this. You've put a lot of work into macros — thanks for that! I'm sorry this has to be shelved for now. Perhaps we'd be able to make a better job when we got a bit more input on what people want.

mks-h commented 2 years ago

Sure! Thank you for being nice and forcing me to use git properly!