search

Koka / gettext-rs

GNU Gettext FFI binding for Rust
51 stars 25 forks source link

Draft: MSVC support #91

Closed nacho closed 2 years ago

nacho commented 2 years ago

Set of commits that allows the library to build using msvc

Minoru commented 2 years ago

Thank you! The CI here failed because of GNU-vs-BSD differences in tar, see #81 for the entire story. We intend to replace the tarball with a Git submodule (see #81 again), but nobody did the work yet. If you're itching to get this merged, it's probably best to do the submodule first, and then the Windows build would be easier.

nacho commented 2 years ago

My idea was actually that the library would be given from outside, i.e using gvsbuild like in this commit or maybe using vcpkg.

nacho commented 2 years ago

@Minoru I've found out that there was already a way to pass the gettext binaries with GETTEXT_BIN_DIR, GETTEXT_LIB_DIR and GETTEXT_INCLUDE_DIR.

So now it builds but the tests are not passing due some mistake in the code

nacho commented 2 years ago

Dropping this for now to avoid so much spam