improve readability of crate and add encode_to_slice

KokaKiwi / rust-hex

A basic crate to encode values to hexadecimal representation. Originally extracted from rustc-serialize.

https://crates.io/crates/hex

Apache License 2.0

201 stars 55 forks source link

improve readability of crate and add encode_to_slice #29

Closed Luro02 closed 4 years ago

Luro02 commented 4 years ago

moved FromHexError to separate file for easier reading
moved traits into a new file (should they be separated?)
added an encode_to_slice function (this can be improved with const generics in the future)
improved the documentation a little bit

LukasKalbertodt commented 4 years ago

👍 from me for the first three commits. (Although I do like "empty" /// lines after /// # Example lines.)

Regarding last commit: I don't have the time to correctly review this. Sounds useful. But maybe this commit should be in a separate PR so that this PR is only about cleanup and such things?

Also: I'm not the owner of this crate, so I don't have anything to say about merging :)

KokaKiwi commented 4 years ago

Regarding last commit: I don't have the time to correctly review this. Sounds useful. But maybe this commit should be in a separate PR so that this PR is only about cleanup and such things?

Same for me, adding new function(s) and moving stuff around should be separated in different PRs

Luro02 commented 4 years ago

Closed in favor of #31 and #32