ci: Improve github actions

KokaKiwi / rust-hex

A basic crate to encode values to hexadecimal representation. Originally extracted from rustc-serialize.

https://crates.io/crates/hex

Apache License 2.0

201 stars 55 forks source link

ci: Improve github actions #56

Closed koushiro closed 3 years ago

koushiro commented 3 years ago

Add code format check & clippy check
Add no_std build
Add MSRV build
Add code coverage (Close #36)
Add more badges

Signed-off-by: koushiro koushiro.cqx@gmail.com

koushiro commented 3 years ago

@KokaKiwi PTAL

I’m not sure whether to delete the validate benchmark part (can speed up the CI check), although cargo clippy --all-targets is enough, I think.

KokaKiwi commented 3 years ago

To be honest, i have a (kinda major) problem with this Pull Request as it sets a MSRV (hex doesn't have one, yet): I would prefer this matter to be handled at another "time" (like, on a separate PR), as it would involve some discussions and reflexions about what would be the "best" version to set as MSRV, especially regarding stuff like const-generic features.

koushiro commented 3 years ago

I just decide the MSRV based on the existing code and features of the hex crate. Of course, you could change it later, as long as it will not cause breaking changes when releasing the new version of the crate.

KokaKiwi commented 3 years ago

Yeah, the test+badge could be changed later, but i would actually prefer if this PR did only CI-related changes, as so when hex MSRV is set the test+badge would be added at this time, not before :)