search

KokoIRC / koko

Yet another IRC client for me and you :koko:
https://github.com/KokoIRC/koko
MIT License
307 stars 27 forks source link

Add basic support for configuring server password #15

Closed mandarg closed 8 years ago

mandarg commented 8 years ago

This diff adds basic support for configuring password, in case you need to auth to the server or a bouncer.

It works correctly for authorizing to my bouncer, and doesn't throw any more warnings than current master after make build and make run. One problem however, is that I haven't been able to figure out how to do password masking. I can add that in another request or this one if you feel that it's blocking. (This is the first React app I've looked at, so I'd be grateful for some pointers about how to do that.)

hatashiro commented 8 years ago

Looks awesome. I'll happily give the pointers.

mandarg commented 8 years ago

I think it should work, the the password field shows as masked now.

Let me know if there is anything else I should do.

mandarg commented 8 years ago

Used the interface solution you suggested instead.

Let me know if you would prefer me to squash the commits and push before you merge the request.

hatashiro commented 8 years ago

No problem. Thanks for the great work! :+1: