KokoIRC / koko

Yet another IRC client for me and you :koko:
https://github.com/KokoIRC/koko
MIT License
307 stars 27 forks source link

Packaging for Linux #3

Open hatashiro opened 9 years ago

hatashiro commented 9 years ago

As I don't use both of them, I will deeply appreciate if somebody can contribute on supporting them. They could be accepted as project maintainers. If this sounds interesting, feel free to contact me!

sindresorhus commented 9 years ago

electron-packager supports OS X, Linux and Windows.

hatashiro commented 9 years ago

Will check it out soon! Many thanks.

danshick commented 9 years ago

I have rewritten much of the build to Gulp. I'll commit and make a pull request, but I have only completed up to the creation of the asar. I still have to download the different electron releases and embed the asar file for dist.

*edit - This will make the build process multi-architecture, but I still have to add custom shells for Windows and Linux. I haven't found a suitable gulp plugin for electron-packager yet.

hatashiro commented 9 years ago

@danshick I'm afraid I'd stick with original Makefile. I'm not a Window guy, but of my knowledge there is still some ways to use Makefile in Windows like cygwin or nmake. I understand they are not so elegant as gulp, but I'd still like to use just make in *nix systems. The build for Windows will still be supported though with electron-packager which will be used in Makefile.

I'm very sorry!

danshick commented 9 years ago

No problem. There is nothing wrong with make either. It was just easier for me to put this together than for me to edit the makefile to support multiple platforms.

hatashiro commented 9 years ago

Thanks for your understanding :smile:

JanWerder commented 9 years ago

So is there anyone working on a windows release?

hatashiro commented 9 years ago

Sorry, not yet! But I'll work on it, hopefully this weekend.

hatashiro commented 9 years ago

Sorry that I couldn't work on this last weekend. I've been busy since the last Friday because of my uni achievements and company works :cry:

It may take for a while and if there's anybody interested, please help!

Keavon commented 8 years ago

Any updates on this?

ewnd9 commented 8 years ago

Anyone build it from sources on linux?

ghost commented 8 years ago

@ewnd9 I was able to build and run it on Ubuntu 15.04 x64 with no issues other than some React warnings, ex: [10630:0903/025907:INFO:CONSOLE(24715)] "Warning: getInitialState was defined on App, a plain JavaScript class. This is only supported for classes created using React.createClass. Did you mean to define a state property instead?", source: file:///../../../koko/build/renderer.js (24715)

I'll try to get a PR out in the next few days for Linux packaging support if my schedule permits it.

hatashiro commented 8 years ago

The warning @k0rupt1 mentioned was fixed with 9da904a5aaf6a0368774f2f1838a6d444b45f026! Thanks for the report.

And finally, Windows binaries are provided with a new release :checkered_flag:. Thank you guys!

And Linux distribution can be done in the similar way. I may not work on this in a while, so please feel free to look into it and send a PR.

0-M commented 7 years ago

On my fork, I'm switching to electron-packager which can build on and package for Mac/Windows/Linux. Testing now.

felipepaes commented 6 years ago

I packed a deb_x64 version of koko. It's working fine here. Elementary OS 0.4.1 Loki - based on Ubuntu 16.04 Xenial. I installed it using Eddy. Someone out there running x64 Debian based distros? It would be great to test it. koko_0.2.1_amd64.deb

screenshot from 2017-07-12 04 34 45