Kolaru / MathTeXEngine.jl

A latex math mode engine in pure Julia.
MIT License
97 stars 19 forks source link

implement \overline command #80

Closed karlwessel closed 1 year ago

karlwessel commented 1 year ago

I implemented the support for the overline command basically by pattern recognition of how the \sqrt implementation works. I can't say I fully understood every line, therefore it would be good if somebody can double check if I missed something. Especially the layout part.

Also added basic tests for parsers and layouts handling of overline.

This fixes issue #79.

codecov-commenter commented 1 year ago

Codecov Report

Base: 79.78% // Head: 80.25% // Increases project coverage by +0.46% :tada:

Coverage data is based on head (c590bf4) compared to base (50f8b4c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ========================================== + Coverage 79.78% 80.25% +0.46% ========================================== Files 7 7 Lines 470 476 +6 ========================================== + Hits 375 382 +7 + Misses 95 94 -1 ``` | [Impacted Files](https://codecov.io/gh/Kolaru/MathTeXEngine.jl/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard) | Coverage Δ | | |---|---|---| | [src/parser/commands\_registration.jl](https://codecov.io/gh/Kolaru/MathTeXEngine.jl/pull/80/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard#diff-c3JjL3BhcnNlci9jb21tYW5kc19yZWdpc3RyYXRpb24uamw=) | `34.78% <ø> (ø)` | | | [src/engine/layout.jl](https://codecov.io/gh/Kolaru/MathTeXEngine.jl/pull/80/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard#diff-c3JjL2VuZ2luZS9sYXlvdXQuamw=) | `90.07% <100.00%> (+0.47%)` | :arrow_up: | | [src/engine/texelements.jl](https://codecov.io/gh/Kolaru/MathTeXEngine.jl/pull/80/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard#diff-c3JjL2VuZ2luZS90ZXhlbGVtZW50cy5qbA==) | `81.57% <0.00%> (+1.31%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Beno%C3%AEt+Richard)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.