Kolifanes / plugin.video.youtube

YouTube for Kodi with API fixed
GNU General Public License v2.0
119 stars 44 forks source link

Recent content type change reduces view options skin #122

Closed RickDB closed 7 years ago

RickDB commented 7 years ago

Issue

In a recent commit ( 542cbfa197d1e9ed14174a060b7f35c63cf4438 ) the content type went from episodes to videos however in Aeon Nox at least this reduces the view options to only list / icons so you see no information only its label.

Workaround

Switched content type back to the original kodion.constants.content_type.EPISODES in code returns all the view types (low_list/ tri-panel etc..) but not sure if this is the right solution.

disrupted commented 7 years ago

yeah, this sucks. also as I believe the manual view override function was removed altogether in this commit. https://github.com/Kolifanes/plugin.video.youtube/commit/6023f7834f9cfd1f09dc3fbb2e47e341d6e9114c

RickDB commented 7 years ago

Reverted that locally as well because otherwise if you navigate it would just use the Kodi default for the content type on every "new" page (my subscriptions -> page 1 -> page 2 etc..)

disrupted commented 7 years ago

@RickDB yeah, I have no idea why it was removed because it was hidden under advanced settings anyways where it shouldn't confuse the average end user. I think it's time to start a fork.

jdf76 commented 7 years ago

It was removed from the request of Kodi Developers as they wanted it this way. There is a unofficial version that adds it back in. We'll be doing 2 versions. 1 Official, 1 unofficial. Look in the forum for the link.

disrupted commented 7 years ago

@jdf76 alright, thanks for the headsup

RickDB commented 7 years ago

Thanks for letting us know :) Will look it up but for auto-update purposes will their be a repo for the unofficial one?

If the repo is external don't see how the Kodi developers can enforce this then, seems like a bit of an overreach from their end tbh. Current way is not user friendly as you now can't tell the video information (channel / date etc..) unless you press Info, but understand the decision.

disrupted commented 7 years ago

@RickDB I have a personal repo where I will push updates of an unofficial version if you're interested, but surely there should be an unofficial repo for everyone to use.

jdf76 commented 7 years ago

Anxdpanic and I are discussing this.

Don’t worry we’ll have it sorted.

Jeff

On Dec 3, 2016, at 12:39 PM, disrupted notifications@github.com wrote:

@RickDB https://github.com/RickDB I have a personal repo https://github.com/disrupted/repo.disrupted/blob/master/repo.disrupted/repo.disrupted-1.0.0.zip?raw=true where I will push updates of an unofficial version if you're interested, but surely there should be an unofficial repo for everyone to use.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Kolifanes/plugin.video.youtube/issues/122#issuecomment-264653552, or mute the thread https://github.com/notifications/unsubscribe-auth/ALozLXnhyGejd1usukaZgvUGd_HIBMGFks5rEalFgaJpZM4LCdl4.