Kolifanes / plugin.video.youtube

YouTube for Kodi with API fixed
GNU General Public License v2.0
118 stars 44 forks source link

Add support for both addon-based (Kodi 17) and built-in (SPMC 16) MPEG-DASH #128

Closed guidosarducci closed 7 years ago

guidosarducci commented 7 years ago

This PR tries to extend DASH support in a clean way to also support built-in implementations as with SPMC. Besides a minor fix, there are three main pieces:

  1. Finish off partial support allowing to identify the application e.g. Kodi, SPMC, etc.
  2. Add hidden settings for built-in and addon-based DASH support. Visible settings depend on these.
  3. Add a startup service using application and version info to initialize the hidden DASH settings

This approach has the advantage of handling downgrades, etc. and populating DASH settings correctly without having to first run the addon. I've tested this on Android with both SPMC 16.5 and Kodi 17b6 without problems.

To make it easier for others to try out I packaged a "5.3.7" version here: plugin.video.youtube-5.3.7-spmc.zip