Open imsodin opened 8 years ago
Hey, is the function to unsubscripe valid? I mean, If you click at subscribe to when you allready done this, can you unsubscripe the channel?
Subscribing to a channel works as expected. If I active "Subscribe to ..." while already being subscribed to a channel this has no effect, there is no notification message and I stay subscribed to the channel. If I choose "Unsubscribe" in the menu "Subscriptions", I successfully unsubscribe from that channel (however it keeps being displayed in "Subscriptions" until you leave this menu and reenter, which is no big issue). So I guess the addon needed to somehow test whether the channel belonging to the video in question is already subscribed when opening the context menu or a bit later when choosing a possible new option "(Un-)Subscribe" and then invoke the correct action unsubscribe or subscribe, which are already correctly implemented.
I hate to ask but if this still an issue and can you run it by me one more time what the issue is.
I think you're saying you can't unsubscribe from a channel, but i'm not really sure where or when you're having this issue.
what I think this is about: in the "my subscriptions" folder you should either have the possibility to unsubscribe from channels (in the context menu it currently always only says "subscribe to") or hide this context menu entry from that page because you're already subscribed to these channels.
freeman212 is quite correct. And the last suggestions is probably the easiest to implement: Just remove the menu entry "Subscribe to..." when one is in "My Subscriptions" as one is obviously already subscribed. I guess the problem is that when opening the context menu on a youtube video (not channel) it is not checked whether I have already subscribed to the channel, which has published that video. Ideally such a check would be done and I would be presented with either "Subscribe to..." if I am not yet subscribed or "Unsubscribe from..." if I already am. However this is not a breaking issue. The UI is not consistent in the current state, but there are ways to subscribe to and unsubscribe from channels - so don't worry if resources aren't here to fix this.
Under "Subscriptions" where all the channels I subscribed to are listed everything works as expected: Opening the context menu of one such channel I get the option to "Unsubscribe". However under "My Subscriptions" where new videos of my subscribed channels are listed, the option "Subscribe to..." is available even though I have already subscribe to this channel (same is true under "Recommendations", not tested in other menues). I would expect to have an option "Unsubscribe from..." if I am already subscribed.