search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
830 stars 93 forks source link

Just selecting a movie set it as unsaved changes state. #1031

Open psonnosp opened 3 years ago

psonnosp commented 3 years ago

Describe the bug I actually don't know if this is an actual bug or not but if it is by design I would like it changed since it has bugged (no phun intended) me for a long time.

If you select an unscraped episode/movie/series it immediately get cursive without any real changes made and if you hit Save or Save All it get saved with a practically empty and useless NFO as result.

To Reproduce Steps to reproduce the behavior:

  1. Select an unscraped episode/movie/series and watch it get cursive as a edited episode/movie/series.

Expected behavior That the episode/movie/series remains in the "new and no changes made" state until you actually scrape or make any changes to it yourself.

MediaElch Version:

Operating System:

bugwelle commented 3 years ago

I have no idea when this happened but I can confirm this. I think it was like this when I started working on MediaElch but I could be wrong here. Very annoying but I do not yet know which fields change (or why). As I currently only have about 1-3h a week for MediaElch, I'll have to prioritize on the new TV scraper interface first. :-/

psonnosp commented 3 years ago

No worries, I'm thankful for every single minute you put down into this so don't feel any pressure, I just report the stuff I find and annoys me enough in case you get any spare time. Hope your exams went well.

bugwelle commented 3 years ago

I just report the stuff I find and annoys me enough in case you get any spare time.

I very much appreciate it! 😃

Hope your exams went well.

Thanks for asking. Yes, they did. :-)

bugwelle commented 3 years ago

Found the bug. Will be fixed by #1072

bugwelle commented 3 years ago

The current nightly does not include the fix, but the next release should contain it. :-)

psonnosp commented 3 years ago

I guess it didn't make it to the next release because I just got the version from December 23 and it isn't fixed. The runtime of the episode/movie is still written out and I guess that's what's triggering it.

bugwelle commented 3 years ago

Will have a look at it again. At least one issue was fixed because in my tests, episodes were not marked as "unsaved" anymore just by clicking them. :-)

psonnosp commented 3 years ago

Sorry my mistake I shouldn't have written episodes, I only checked it on movies and there the runtime is still written out upon selection and I guess it might have something to do with it.

bugwelle commented 10 months ago

Ok, after forgetting about this issue for 3 years, I had a look: It should be "fixed". Fixed in the sense that new movies without an NFO file will be marked "changed" once they are accessed. That is because to MediaElch, creating a NFO (in memory) is considered "changed", hence the text being cursive.

bugwelle commented 10 months ago

Besides that, I couldn't reproduce it anymore.

ironhussar commented 1 month ago

To revive an old issue, this still happens. I have a few movies in my list that I have not scraped yet, and clicking them always turns the text to italic and saving generates a blank nfo. This happens every time.

Sometimes, when I start the program, it will automatically choose the first entry in the list (which is an unscraped movie). This doesn't always happen though.