Closed TimB87 closed 3 years ago
Have you checked the latest master? Does it still happen there?
I always run MediaElch with Google's AddressSanitizer enabled. I thought I fixed this issue...
This is with 2.6.7-dev, shall I still compile and try master?
v2.6.7-dev has been around since March. :)
Would be great if you could try the latest master. Thank you 😃
Pardon me, I am trying 2.7.0-dev right now 😬 The bug report only stated 2.6.7 and I didn't double check 😪
Thanks! :-)
What scraper are you using and what movie do you scrape? I'll try this on a Linux machine in the next days.
Hey! Sorry for the late answer.
It doesn't really make any difference which scraper I use (as far as I can tell at least) - but in the posted snipped I was using The Movie DB, and the movie is "Stargate: Continuum (2008)". Thanks for looking into it 😀
hmm... Tested with:
Will test other setups as well. Seems to be a race condition... Oh man.
Snap. I am afraid coding wise I might not be of any help here :| but if I can help debugging in any way please let me know!
Could you compile MediaElch in Debug mode and test it again? And if it fails could you paste the stacktrace (like the one you posted before?)? :smiley:
I'm 95% sure it's a bug in our DownloadManager.
This maybe a dumb question, currently I use qmake to build (as cmake fails to locate external quazip [as does qmake, but that i have solved with some seds and i haven't spend much time on the cmake approach yet]) - how do I build the debug version with qmake?
It should work with qmake CONFIG+=debug
:-)
See https://doc.qt.io/qt-5/qmake-variable-reference.html#config
I hope this is correct, steps taken:
gdb MediaElch
set logging file elk.log
set logging on
run
steps in op
bt
The gdb output to stdout looks different:
(gdb) run
2020-12-08 16:15:11.044 DEBUG [../src/settings/AdvancedSettingsXmlReader.cpp:22] | Loading advanced settings from: FilePath("/home/tim/.local/share/kvibes/MediaElch/advancedsettings.xml")
2020-12-08 16:15:11.044 WARN [../src/settings/AdvancedSettingsXmlReader.cpp:31] | [AdvancedSettings] advancedsettings.xml not found at "/home/tim/.local/share/kvibes/MediaElch/advancedsettings.xml"
2020-12-08 16:15:11.044 DEBUG [../src/settings/Settings.cpp:65] | Advanced settings:
locale: German (Germany)
debugLog: false
logFile:
forceCache: false
stylesheet: <bundled>
sortTokens: Der, Die, Das, The, Le, La, Les, Un, Une, Des
movieFilters: *.mkv, *.mk3d, *.avi, *.mpg, *.mpeg, *.mp4, *.m2ts, *.disc, *.m4v, *.strm, *.dat, *.flv, *.vob, *.ts, *.iso, *.ogg, *.ogm, *.rmvb, *.img, *.wmv, *.mov, *.divx, VIDEO_TS.IFO, index.bdmv, *.wtv
concertFilters: *.mkv, *.mk3d, *.avi, *.mpg, *.mpeg, *.mp4, *.m2ts, *.disc, *.m4v, *.strm, *.dat, *.flv, *.vob, *.ts, *.iso, *.ogg, *.ogm, *.rmvb, *.img, *.wmv, *.mov, *.divx, VIDEO_TS.IFO, index.bdmv, *.wtv
tvShowFilters: *.mkv, *.mk3d, *.avi, *.mpg, *.mpeg, *.mp4, *.m2ts, *.disc, *.m4v, *.strm, *.dat, *.flv, *.vob, *.ts, *.iso, *.ogg, *.ogm, *.rmvb, *.img, *.wmv, *.mov, *.divx, VIDEO_TS.IFO, index.bdmv, *.wtv
subtitleFilters: *.idx, *.sub, *.srr, *.srt, *.ass, *.ttml
genreMappings:
audioCodecMappings:
aac lc: aac
mpa1l3: mp3
mpa1l2: mp2
videoCodecMappings:
avc: h264
v_mpeg4/iso/avc: h264
certificationMappings:
studioMappings:
countryMappings:
writeThumbUrlsToNfo: true
episodeThumb dimensions:
width: 400
height: 300
bookletCut: 2
useFirstStudioOnly: false
exclude patterns:
2020-12-08 16:15:11.076 DEBUG [../src/scrapers/movie/TMDb.cpp:252] | [TMDb] Request setup from server
2020-12-08 16:15:11.081 DEBUG [../src/scrapers/movie/TMDb.cpp:252] | [TMDb] Request setup from server
2020-12-08 16:15:11.083 INFO [../src/globals/ScraperManager.cpp:121] | [TvScraper] Initializing "TMDb TV"
2020-12-08 16:15:11.085 INFO [../src/globals/ScraperManager.cpp:121] | [TvScraper] Initializing "TheTvDb"
2020-12-08 16:15:11.085 INFO [../src/globals/ScraperManager.cpp:121] | [TvScraper] Initializing "IMDb TV"
2020-12-08 16:15:11.159 DEBUG [../src/scrapers/movie/TMDb.cpp:252] | [TMDb] Request setup from server
2020-12-08 16:15:11.160 DEBUG [../src/scrapers/movie/TMDb.cpp:252] | [TMDb] Request setup from server
2020-12-08 16:15:12.186 INFO [../src/ui/imports/DownloadsWidget.cpp:84] | [DownloadsWidget] Start scanning for imports/downloads. Start Timer.
2020-12-08 16:15:12.459 DEBUG [../src/ui/main/MainWindow.cpp:75] | MediaElch version "2.6.7-dev" starting up
ATTENTION: default value of option allow_rgb10_configs overridden by environment.
2020-12-08 16:15:13.078 INFO [../src/ui/main/MainWindow.cpp:272] | Searching for updates
2020-12-08 16:15:13.119 INFO [../src/globals/ScraperManager.cpp:124] | [TvScraper] Initialized: "IMDb TV"
2020-12-08 16:15:13.132 INFO [../src/ui/imports/DownloadsWidget.cpp:475] | [DownloadsWidget] Scanning for imports/downloads took: 945 ms
2020-12-08 16:15:13.132 INFO [../src/ui/imports/DownloadsWidget.cpp:493] | [DownloadsWidget] Updating imports/downloads lists: 0 ms
2020-12-08 16:15:13.143 DEBUG [../src/movies/file_searcher/MovieFileSearcher.cpp:104] | [MovieFileSearcher] Adding movie directory "/media/NAS/Filme"
2020-12-08 16:15:13.143 DEBUG [../src/tv_shows/TvShowFileSearcher.cpp:40] | [TvShowFileSearcher] Adding TV show directory "/media/NAS/Serien"
2020-12-08 16:15:13.143 DEBUG [../src/music/MusicFileSearcher.cpp:34] | [MusicFileSearcher] Adding music directory "/media/NAS/Musik"
2020-12-08 16:15:13.364 DEBUG [../src/scrapers/movie/TMDb.cpp:303] | [TMDb] Base url: "http://image.tmdb.org/t/p/"
2020-12-08 16:15:13.365 INFO [../src/globals/ScraperManager.cpp:124] | [TvScraper] Initialized: "TMDb TV"
2020-12-08 16:15:13.365 DEBUG [../src/scrapers/movie/TMDb.cpp:303] | [TMDb] Base url: "http://image.tmdb.org/t/p/"
2020-12-08 16:15:13.365 DEBUG [../src/scrapers/movie/TMDb.cpp:303] | [TMDb] Base url: "http://image.tmdb.org/t/p/"
2020-12-08 16:15:13.365 DEBUG [../src/scrapers/concert/TMDbConcerts.cpp:210] | TMDb base url: "http://image.tmdb.org/t/p/"
2020-12-08 16:15:13.365 DEBUG [../src/scrapers/movie/TMDb.cpp:303] | [TMDb] Base url: "http://image.tmdb.org/t/p/"
2020-12-08 16:15:13.402 DEBUG [../src/movies/file_searcher/MovieFileSearcher.cpp:271] | Scanning directory: QDir( "/media/NAS/Filme" , nameFilters = { "*" }, QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntr
ies ) )
2020-12-08 16:15:13.697 DEBUG [../src/movies/file_searcher/MovieFileSearcher.cpp:54] | Now processing files
2020-12-08 16:15:13.810 DEBUG [../src/scrapers/tv_show/thetvdb/TheTvDbApi.cpp:25] | [TheTvDbApi] Received JSON web token
2020-12-08 16:15:13.810 INFO [../src/globals/ScraperManager.cpp:124] | [TvScraper] Initialized: "TheTvDb"
2020-12-08 16:15:14.312 WARN [../src/media_centers/kodi/MovieXmlReader.cpp:29] | [MovieXmlReader] No <movie> tag in the document
2020-12-08 16:15:14.331 INFO [../src/tv_shows/TvShowFileSearcher.cpp:48] | [TvShowFileSearcher] Reload TV shows, clear database: false
2020-12-08 16:15:22.101 DEBUG [../src/tv_shows/TvShowFileSearcher.cpp:73] | [TvShowFileSearcher] Searching for TV shows done
2020-12-08 16:15:22.101 INFO [../src/ui/imports/DownloadsWidget.cpp:84] | [DownloadsWidget] Start scanning for imports/downloads. Start Timer.
2020-12-08 16:15:22.102 INFO [../src/ui/imports/DownloadsWidget.cpp:475] | [DownloadsWidget] Scanning for imports/downloads took: 0 ms
2020-12-08 16:15:22.102 INFO [../src/ui/imports/DownloadsWidget.cpp:493] | [DownloadsWidget] Updating imports/downloads lists: 0 ms
2020-12-08 16:15:22.116 DEBUG [../src/ui/tv_show/TvShowFilesWidget.cpp:489] | [TvShowFilesWidget] Renewing model | Forced: true
2020-12-08 16:15:22.164 DEBUG [../src/concerts/ConcertFileSearcher.cpp:60] | Searching for concerts done
2020-12-08 16:15:34.945 DEBUG [../src/ui/movies/MovieWidget.cpp:379] | Entered, movie= "2008 - Stargate Continuum"
2020-12-08 16:15:35.051 WARN [unknown:0] | QPixmap::scaleHeight: Pixmap is a null pixmap
2020-12-08 16:15:35.051 WARN [unknown:0] | QPainter::begin: Paint device returned engine == 0, type: 2
2020-12-08 16:15:35.051 WARN [unknown:0] | QPainter::setCompositionMode: Painter not active
2020-12-08 16:15:35.051 WARN [unknown:0] | QPainter::end: Painter not active, aborted
2020-12-08 16:15:35.051 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= true
2020-12-08 16:15:35.053 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= true
2020-12-08 16:15:35.053 DEBUG [../src/ui/main/MainWindow.cpp:551] | [MainWindow] Search field: enabled
2020-12-08 16:15:35.054 DEBUG [../src/ui/movies/MovieWidget.cpp:351] | "2008 - Stargate Continuum"
2020-12-08 16:15:35.054 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= true
2020-12-08 16:15:35.054 DEBUG [../src/ui/main/MainWindow.cpp:551] | [MainWindow] Search field: enabled
2020-12-08 16:15:35.584 DEBUG [../src/ui/main/MainWindow.cpp:375] | Entered, currentIndex= 0
2020-12-08 16:15:35.584 DEBUG [../src/ui/main/MainWindow.cpp:551] | [MainWindow] Search field: disabled
2020-12-08 16:15:35.584 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= false
2020-12-08 16:15:35.593 DEBUG [../src/ui/movies/MovieSearch.cpp:34] | [MovieSearch] Open window
2020-12-08 16:15:35.593 DEBUG [../src/scrapers/movie/TMDb.cpp:313] | Entered, searchStr= "2008 - Stargate Continuum"
2020-12-08 16:15:35.734 DEBUG [../src/ui/movies/MovieSearchWidget.cpp:156] | [Search Results] Count: 0
2020-12-08 16:15:35.734 DEBUG [../src/ui/movies/MovieSearchWidget.cpp:156] | [Search Results] Count: 0
2020-12-08 16:15:38.973 DEBUG [../src/scrapers/movie/TMDb.cpp:313] | Entered, searchStr= "Continuum"
2020-12-08 16:15:39.110 DEBUG [../src/ui/movies/MovieSearchWidget.cpp:156] | [Search Results] Count: 16
2020-12-08 16:15:39.110 DEBUG [../src/ui/movies/MovieSearchWidget.cpp:156] | [Search Results] Count: 16
2020-12-08 16:15:40.547 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= false
2020-12-08 16:15:40.547 DEBUG [../src/ui/main/MainWindow.cpp:551] | [MainWindow] Search field: disabled
2020-12-08 16:15:40.547 DEBUG [../src/ui/notifications/NotificationBox.cpp:105] | Entered, message= "Lade..." id= 20062
2020-12-08 16:15:40.857 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= true
2020-12-08 16:15:40.859 DEBUG [../src/ui/main/MainWindow.cpp:516] | Entered, enabled= false
2020-12-08 16:15:40.859 DEBUG [../src/scrapers/image/FanartTv.cpp:309] | [FanartTv] Load movie data with image types: QUrl("https://webservice.fanart.tv/v3/movies/12914?api_key=842f7a5d1cc7396f142b8dd47c4ba42b")
2020-12-08 16:15:41.088 DEBUG [../src/ui/notifications/NotificationBox.cpp:154] | [NotificationBox] Hide Progress bar with id 20062
2020-12-08 16:15:41.088 DEBUG [../src/ui/notifications/NotificationBox.cpp:84] | Entered, id= 20062
2020-12-08 16:15:41.088 DEBUG [../src/ui/main/MainWindow.cpp:344] | Entered, msg= "Lade Bilder..." id= 20062
2020-12-08 16:15:41.088 DEBUG [../src/ui/notifications/NotificationBox.cpp:105] | Entered, message= "Lade Bilder..." id= 20062
2020-12-08 16:15:41.089 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("http://image.tmdb.org/t/p/original/exCFVhFQWnVbGPbr2JeTQwK7Mgw.jpg")
2020-12-08 16:15:41.089 DEBUG [../src/globals/DownloadManager.cpp:158] | [DownloadManager] Start next download
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("http://image.tmdb.org/t/p/original/jT7tdu9ksHkdS4R13ieXNs5efYW.jpg")
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/movies/12914/hdmovielogo/stargate-continuum-5209f4e1a6922.png")
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/movies/12914/hdmovieclearart/stargate-continuum-520d3e3b180f8.png")
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/movies/12914/moviedisc/stargate-continuum-52664e819ae72.png")
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/movies/12914/moviebanner/stargate-continuum-520bf8ae11239.jpg")
2020-12-08 16:15:41.090 DEBUG [../src/globals/DownloadManager.cpp:37] | [DownloadManager] Enqueue download | QUrl("https://assets.fanart.tv/fanart/movies/12914/moviethumb/stargate-continuum-520d41c19f56e.jpg")
(gdb)
Another edit: sorry, I just realized there are more tickets opened for that issue 😪
Thank you for the elk.log
file!
I see this line:
#2 0x00007fffefdcb8e4 in Kvantum::Style::advanceProgressbar() () from /usr/lib/qt5/plugins/styles/libkvantum.so
It didn't occur to me but we may have a race condition when we update the progress bar... Signals and Concurrency is difficult...
OffTopic: Do you use this theme? https://github.com/tsujan/Kvantum/tree/master/Kvantum 😄
Another edit: sorry, I just realized there are more tickets opened for that issue 😪
I know. But I couldn't fix it, yet. 😭 I'll leave this issue open. Thank you for testing MediaElch!
yes, i use kvantum, i noticed it as well. I can try without kvantum in a bit and see if that makes any difference :-) but it'll have to wait for a bit
No you don't have to, other users have reported it with different systems. :-) It's an issue with MediaElch.
Ok, scrap the it has to wait part. I went with the quick and dirty method and removed kvantum completly for a second, scraping that movies information was now possible!
Maybe it's your refactored code for the new release, but it's also considerably fetching stuff faster.
I haven't touched the movie scrapers but I'm glad to hear that. 😄 Ok, so it's the parallel updating of the progress bar that crashes the software on some systems...
You don't happen to have a quick start guide for CRUX with kvantum, do you? If I can't figure out what may be wrong then I have to reproduce it somehow. :)
a very old quickstart but not much has changed (well, UEFI is now a thing, if you don't virtualize). The handbook really isn't that long. kvantum and mediaelch are in contrib repository, which needs to be enabled, I maintain both those ports. kvantum needs another repository enabled: kde5 repository by T. Henschel
If you don't feel hyped about configuring your own kernel, a quick and dirty solution is to take someone elses :D like arch or ubuntu. You could still do a make localyesconfig
afterwards and then do some more changes without weeding through the wild.
After having the box setup it's condensed to:
ports -u
prt-get depinst $someWMorDM kvantum mediaelch
(I use i3 on my desktop, sway on my notebook - both with kvantum and the error described here)CRUX 3.6 was just released some minutes ago, I was doing all that on 3.5. It should be the same, but it might make sense to utilize 3.5 if you want to test it yourself. Feel free to shoot me more questions about it (freenode -> beerman)! For now, I'll have to run :-)
Hi,
I've opened a PR which may (or may not) fix this issue. Could you test it with kvantum? I haven't reproduced the bug, yet.
git clone https://github.com/bugwelle/MediaElch.git
git checkout downloadmanager # branch with fixes
mkdir build
cd build
qmake .. CONFIG+=release
make -j$(nproc)
Ok, wait.. There's a new issue. I'll let you know when the PR is ready for testing.
Ok, ready to go :-)
Hi! Sorry, I haven't found the time yesterday. I tried it now between sessions and same error with the Series "Money Heist":
0x00007ffff794da45 in void QWidgetPrivate::update<QRect>(QRect) () from /usr/lib/libQt5Widgets.so.5
I tried a few times now and always hit it again.
Oh no... :/ Ok. Then I'll set up a VM.
If you do it with CRUX, please take 3.5 for this test, I am in the process of updating my notebook but it'll take me some time, so I can't tell anything about that yet. And if you run into questions, feel free to join #crux on freenode or hit me up directly. Thanks for digging into it!
Could you also try out this PR? https://github.com/Komet/MediaElch/pull/1077
git checkout paralleldownloadmanager # branch with fixes
I checked my Kubuntu System with kvantum and MediaElch didn't crash with the current master... Will look into your distro. :)
Closing in favor of #1060
I was able to reproduce the crash there.
Hi! Sorry, I had troubles with some hardware failing on my Desktop where I tried it all, this sounds great! I will try out master in a bit, I just got it booted again
Master branch won't help you. :-)
If a branch works (and I haven't tested it) then paralleldownloadmanager
from #1077 but I don't think it will help.
Indeed, it doesn't work :| Sorry I won't be of much coding help with that, if you need someone to test it though, feel free to tag me!
Hi,
I just wanted to inform you that I was able to reproduce this issue on Manjaro XFCE and that the bug will be fixed by #1078. Turns out that this bug only happened with Kvantum installed which is why I wasn't able to reproduce this bug (I used Manjaro KDE for testing before...).
Regards, Andre
@TimB87 Thanks. I'm 99% sure that #1078 will fix this issue once and for all. :smile:
@bugwelle indeed it does seem to do that 🎊
Thank you so much for confirming it! :smile:
Describe the bug I have had that since I use MediaElch (maybe the past 2 or 3 versions) and with some files, it randomly happens - it may work after restarting - but I have some that always fail with a segfault.
To Reproduce Steps to reproduce the behavior:
qt5 version is 5.15.2 and is compiled on this machine. I have no other faults with qt applications and this is reproducible on another machine I use.
Expected behavior It does not segfault while it fetches informations.
MediaElch Version:
Operating System: