search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
832 stars 93 forks source link

Remove TheTvDb #1120

Open bugwelle opened 3 years ago

bugwelle commented 3 years ago

Because TheTvDb moves to a paid model, remove their API from MediaElch. I do not plan to pay for their service.

I created this issue in case that there are users that plan to subscribe to their service. If so, please reply to this issue.

spooki3 commented 3 years ago

I might subscribe since noticing some tv shows don't properly update using tmdb after I started scriping them using tvdb. I also notice season fanart not being loaded using tmdb, but that might be an issue on my side in the settings. I older version could choose the season fanart from either tvdb or fanart.tv

Next (tt9315054) is one of them. Scraped as neXt (2020) from tvdb but added with different name (Next) on tmdb and will probably encounter more differences. Don't feel like resraping everything again and might just pay for tvdb.

bugwelle commented 3 years ago

hmm.. Ok. I may contact them and ask for a developer key. Otherwise I have to read their API and hope that I get it right without testing it. Or I may actually pay 12$ once. I'll see. :-)

But at the moment their site is broken... I can't even get to their API key page ( https://thetvdb.com/dashboard/account/apikey ). It just redirects me to the main page...

txtsd commented 3 years ago

thetvdb is not known for maintaining a stable or documented API.

bugwelle commented 3 years ago

Yeah, I know.... :-/

spooki3 commented 3 years ago

yeah it definitely not the most reliable service.. Though I kinda rely on it together with fanart.tv for the season fanart for my tv shows. I prefer imdb for some of the information and i do like tmdb. But both don't have fanart.

I do love all the work you have put into it. In th epast I have paid for meiaelch. Is there anyway to make a contribution for all your hard word?

bugwelle commented 3 years ago

Wow, even when they want to switch to a paid model, their API is unreliable as always... Suddenly my scraper tests for "Scrubs" in German fail. TheTvDb returns a 404... Wow... English or Danish still works but out of the blue, German fails.

mikeperalta1 commented 3 years ago

I'm not interested in TheTVDB but if you're going to purchase the API, let me donate the $12 to you. Send me a PM if you're interested.

bugwelle commented 3 years ago

Thanks. I opened a ticket on TheTvDb and I can create a developer account without any costs. If I find time, I'll look into how many changes are required for TheTvDb v4 to work. :)

bugwelle commented 3 years ago

The "TheTvDb" API is bad. Really bad. As far as I can see, I can no longer search for series in other languages. I'll open a ticket for that. If I search for the series "The Simpson", then I still get translated names, but they are encoded in a JSON string:

"name_translated": "{\"por\": \"Os Simpsons\", \"lav\": \"Simpsoni\", \"tur\": \"Simpsonlar\", \"ces\": \"Simpsonovi\", \"pol\": \"Simpsonowie\", \"ita\": \"I Simpson\", \"fin\": \"Simpsonit\", \"kor\": \"심슨 가족\", \"hun\": \"A Simpson család\", \"fra\": \"Les Simpson\", \"nld\": \"The Simpsons\", \"pt\": \"Os Simpsons\", \"hrv\": \"Simpsoni\", \"spa\": \"Los Simpson\", \"deu\": \"Die Simpsons\", \"rus\": \"Симпсоны\" }",

Like... Your response is already JSON?!? Why encode it again?

bugwelle commented 3 years ago

https://twitter.com/thetvdb/status/1371971040180543488

We have until October 🎉

osscombat commented 3 years ago

Does https://www.themoviedb.org/ API got paid as well?

bugwelle commented 3 years ago

@osscombat No, they offer a free service. MediaElch also supports TMDb for series. :-)

osscombat commented 3 years ago

hmm, strange, I'm getting timeouts from the Scraper...

чт, 18 мар. 2021 г., 11:08 Andre Meyering @.***>:

@osscombat https://github.com/osscombat No, they offer a free service. MediaElch also supports TMDb for series. :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Komet/MediaElch/issues/1120#issuecomment-801719456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ2YGNW5ORNDUN7MYQHH3DTEGYINANCNFSM4VFQVTSA .

bugwelle commented 3 years ago

Please check your internet connection. If TMDb continues to not work, please open another issue. :-) Tested it just now and works on my side.

ticao2 commented 3 years ago

hmm, strange, I'm getting timeouts from the Scraper... чт, 18 мар. 2021 г., 11:08 Andre Meyering @.***>: …

If you are in Russia, Moscow residents are having trouble accessing the TMDb API servers. https://www.themoviedb.org/talk/6036ee9d4fd141003eae8534

osscombat commented 3 years ago

thought about it, but this issue is resolved for now

пт, 19 мар. 2021 г., 6:24 ticao2 @.***>:

hmm, strange, I'm getting timeouts from the Scraper... чт, 18 мар. 2021 г., 11:08 Andre Meyering @.***>: … <#m7653125549870889446> @osscombat https://github.com/osscombat https://github.com/osscombat No, they offer a free service. MediaElch also supports TMDb for series. :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1120 (comment) https://github.com/Komet/MediaElch/issues/1120#issuecomment-801719456>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ2YGNW5ORNDUN7MYQHH3DTEGYINANCNFSM4VFQVTSA .

If you are in Russia, Moscow residents are having trouble accessing the TMDb API servers. https://www.themoviedb.org/talk/6036ee9d4fd141003eae8534

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Komet/MediaElch/issues/1120#issuecomment-802518492, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ2YGLFOVVKYCCDP46DWT3TEK7WZANCNFSM4VFQVTSA .

bugwelle commented 3 years ago

I can no longer search for series in other languages. I'll open a ticket for that.

Today I got a response (just 25 days 🎉 ) that they have forwarded the issue to the developers. :)

bugwelle commented 3 years ago

Next issue: https://github.com/thetvdb/v4-api/issues/33

Can't login at the moment. The same code used to work in April...

bugwelle commented 3 years ago

Ok, so I didn't test their API for a few months because they were missing features. And now, when I want to test it again, I suddenly need a PIN to access their API. No statement about when this changed. Nothing.

I'm told that I can re-apply for a key and get a (free) pin for developers but seriously? I went through this once.

Their API is unreliable, and the communication about such changes non-existent.

For those that would like to keep using TheTvDb, I'm sorry, but I've decided to just remove TheTvDb altogether.

elschman commented 2 years ago

Any other good reliable source for TV Series all around the world ?

May be a sponsoring for a api key would be an idea ? Would this make your decision reversible ?

bugwelle commented 2 years ago

Hi,

I've decided for me personally not to support TheTvDb anymore and instead move to TMDb. I don't have the time to update the TheTvDb scraper. Only if another developer agrees to implement, update and support TheTvDb, it will be restored to MediaElch.

Regards, Andre