search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
845 stars 94 forks source link

episodeguide url is for thetvdb when trying to use tmdb #1233

Closed ukoda closed 3 years ago

ukoda commented 3 years ago

Kodi v19 appears to want to use the tmdb scrapper but some TV series are not appearing. Even after setting everything I can find to tmdb the generated tvshow.nfo references tvdb in key places and as the default.

To Reproduce For TV series "World Witches Take Off! (2021)" at https://www.themoviedb.org/tv/106386?language=en-US. Steps to reproduce the behavior:

  1. Go to settings -> Scraper -> Custom TV Scraper and change every site possible to "TMDb TV".
  2. In the main window click on "Shows".
  3. Select "World Witches Take Off" in left column.
  4. Click on "Scrape" button. Check scraper shows as "TMDb TV".
  5. Chose "Update TV Show and all Episodes"
  6. Click on the single show found result.
  7. After scraping is complete click on "Save button".

Expected behavior A tvshow.nfo file to be created in the show's folder that references tmdb in the important areas. However the default "uniqueid" is for tvdb and the "url" in the "episodeguide" points to api.thetvdb.com.

From the Kodi documentation it would appear to the likely reason Kodi is failing to scrape and not showing this show.

MediaElch Version:

Operating System:

Additional context The generated file should be attached tvshow.nfo.zip

bugwelle commented 3 years ago

Oh. That surprises me. Kodi shouldn't scrape more details. Only NFO meta data should be used. Thanks you for reporting this issue!

bugwelle commented 3 years ago

If I use the NFO provided by you, the TV show appears in Kodi.

What I'll fix ASAP is that an empty TvDbId can appear: <uniqueid type="tvdb" default="true">0</uniqueid>

bugwelle commented 3 years ago

Ok, for TMDb, NFOs scraped with Kodi v19 look like this:

    <episodeguide>1434</episodeguide>
    <id>1434</id>
    <uniqueid type="imdb">tt0182576</uniqueid>
    <uniqueid type="tmdb" default="true">1434</uniqueid>

So it's rather easy to implement. Use the new format for v19 and TMDb. Use TvDb as fallback.

bugwelle commented 3 years ago

https://github.com/Komet/MediaElch/pull/1234 will fix this issue. MediaElch will then write the TMDb ID as the episodeguide URL per default.

And the new order for the default uniqueid is:

  1. TMDB
  2. TvDb
  3. IMDb
  4. TvMaze