Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
842 stars 94 forks source link

Scraper dialog replaces movie title by ID which does not match the currently selected scraper #1496

Open danilovesky opened 1 year ago

danilovesky commented 1 year ago

Describe the bug When switching between scrapers in Scrape dialog (the one open with Ctrl+F), the movie title is automatically replaced by database ID that may not recognised by the currently selected scraper.

To Reproduce Steps to reproduce the behavior:

  1. Select a "correctly named" movie, so it would be easily identified by a scraper.
  2. Go to Scraper dialog (Ctrl+F) and use //The Movie DB// scraper to find the movie details. Click on the found movie item to scrap its related info and artwork.
  3. Now open the Scraper dialog again -- notice that the movie name is replaced by //TMDb ID/ at this stage.
  4. Select //IMDB// scraper (e.g. to fetch additional artwork) -- observe that no results are found, as the movie title has //TMDb ID// which is unknown to IMDB scraper.
  5. Close the Scraper dialog and open it again. Now the movie title is replaced by //IMDb ID// and the movie details are successfully found by IMDB scraper.

Expected behavior I see two possible solutions:

Option A (my preference): Preserve the movie name intact, i.e. do not replace it by the TMBDb ID or IMDb ID -- that would enable a selected scraper to do its job based on the actual movie name.

Option B: (may be fiddly to implement) Keep track of the selected scraper ad use its movie ID when replacing the movie title in the search box.

Screenshots

MediaElch Version:

Operating System:

Additional context The same behaviour is exhibited when switching to other scrapers, not just //The Movie DB// and //IMDB// -- automatically inserted database ID "spoils" the search results.

bugwelle commented 1 year ago

Thanks for reporting. That has been annoying me as well. This feature comes from a time where IMDb IDs were used for all scrapers. I've recently started working on https://github.com/Komet/MediaElch/pull/1163 again, in which I try to solve this.