search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
843 stars 94 forks source link

Artwork doesn't overwrite when it should. #1628

Open Metal-Snake opened 1 year ago

Metal-Snake commented 1 year ago

Describe the bug When scraping a an already scraped movie, the artwork doesn't get overwritten. This can be annoying in two situations:

  1. Wanting to update the artwork
  2. When scraping a movie, saving and later realizing it was the wrong movie.

To Reproduce Steps to reproduce the behavior:

  1. Go to Move
  2. Scrape movie with wrong data
  3. Save
  4. Scrape move with correct data
  5. artwork stays the same

Expected behavior If the checkboxes for the artworks are selected, the artwork should be overwritten.

Screenshots Scraped data with Kiki's delivery service anime from 1989:

Bildschirmfoto 2023-07-31 um 21 25 28

Scraped again with the correct Kiki's delivery service movie from 2014

Bildschirmfoto 2023-07-31 um 21 26 19

MediaElch Version:

Operating System:

Additional context It seems like Logo, Preview and Banner aren't affected by this

bugwelle commented 1 year ago

Thanks for reporting! I found and fixed a few bugs in regards to artwork files in the past, and I'm sure there are many more. I never touched the artwork handling since I started working on MediaElch :smile:

Note to self: Should look like:

Screenshot_20230731_213149

Metal-Snake commented 1 year ago

I needed to remove the .nfo now, it wouldn't load the correct artworks even after deleting the artwork in Media Elch. After saving the artwork files were deleted, but after scraping it again loaded the wrong artworks. I think it's because the urls to the artworks were saved in the .nfo file.

bugwelle commented 1 year ago

Thanks. I had hoped it was some name ambiguity, but scraping "Avatar" does not work either...

Ok, this is a high priority bug. But I will likely not get to work on it this week.

Deleting the <poster> tags from the NFO works. My guess: We use fanart.tv for some images. But we fallback to the <poster> tags. But in this case it may be the other way around: The <poster> has priority. To be investigated...

bugwelle commented 1 year ago

I didn't get to work on it, yet, but it's on the top of my priority list. I'm on vacation for the next two weeks, and will work on this issue after that.

Thanks for reporting it and being patient. :)

Metal-Snake commented 1 year ago

no problem, take your time and have a great vacation! :)

(btw. had to change my nick, I was Diskutant, now I am Metal-Snake ;) )