Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
842 stars 94 forks source link

Different behavior loading images when using different scapers. #1646

Open Metal-Snake opened 1 year ago

Metal-Snake commented 1 year ago

Describe the bug Using the TMDB scraper for a movie, the checkboxes look like this:

Bildschirmfoto 2023-09-09 um 09 45 02

all images are enabled, and the images are loaded, even though some images like logo are only available from fanart.tv. So it seems here it uses a fallback, this is imho the wanted behavior because those images are only available from fanart.tv and they serve only images and no data.

When using the IMDB scraper to load a movie, the checkboxes look like this:

Bildschirmfoto 2023-09-09 um 09 42 44

fanart, logo etc won't get loaded because those are not available from IMDB and it doesn't seem to fallback. This same behavior is true for series for both, IMDB and TMDB, scraper.

To Reproduce Steps to reproduce the behavior:

  1. scrape new movies and series using tmdb and imdb scraper
  2. see which images get loaded, and which aren't even though they are available from fanart.tv

Expected behavior I would expect the scrapers to always use fanart.tv for the images which the scrapers themselves don't serve.

MediaElch Version:

Operating System:

bugwelle commented 1 year ago

Thanks for reporting. The image-loading feature is not consistent. Sometimes, e.g. for TMDb (if I remember correctly), image URLs for fanart.tv are scraped. For other scrapers, that's not the case.