search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
831 stars 93 forks source link

[TMDb TV] `<status>` for Continuing and Canceled series displayed and stored incorrectly #1679

Open mihawk90 opened 10 months ago

mihawk90 commented 10 months ago

Describe the bug The status for continuing and returning series are not displayed in the UI. They are stored in the NFO, however from what I can tell the stored values are incorrect.

To Reproduce

  1. Get some series with varying status, for example:
  2. Scrape all 3 series and check the status
  3. Only Castlevania will be filled as "Ended", which is correct, the other 2 will be empty
  4. Save all 3 series and check the NFO
    • :heavy_multiplication_x: 2 Broke Girls will say <status>Canceled</status>
    • :heavy_multiplication_x: Arcane will say <status>Returning Series</status>
    • :heavy_check_mark: Castlevania will say <status>Ended</status>

Expected behavior ME should store the correct status. I think this is probably a leftover from TheTVDB since from what I can tell they only have "Continuing" and "Ended" so the Scraper is probably just dumping whatever the API returns into the NFO. According to the Kodi Wiki on NFOs only "Continuing" and "Ended" are accepted. It also references the source code but I couldn't read much out of it whether it also accepts different values. I can however say that Jellyfin for one only supports these 2 and will display the year wrong if an invalid value is read from the NFO:

image image (although it doesn't always seem to do that :shrug: )

According to the TMDb docs there is also "In Production" but I don't think it makes much sense for a media manager anyway.

MediaElch Version:

Operating System:

bugwelle commented 10 months ago

the Scraper is probably just dumping whatever the API returns into the NFO.

Correct.

I propose to map certain values to "Ended" and "Continuing".

Maps to "Ended":

Maps to "Continuing":

mihawk90 commented 10 months ago

Maps to "Continuing":

.. also Returning Series ;)